Forwarding POST body into renderer after a cross-site transfer.

content/common/navigation_params.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/navigation_params.h"
 
 #include "build/build_config.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/url_constants.h"
@@ skipping 44 matching lines @@
       navigation_type(navigation_type),
       allow_download(allow_download),
       should_replace_current_entry(should_replace_current_entry),
       ui_timestamp(ui_timestamp),
       report_type(report_type),
       base_url_for_data_url(base_url_for_data_url),
       history_url_for_data_url(history_url_for_data_url),
       lofi_state(lofi_state),
       navigation_start(navigation_start),
       method(method),
-      post_data(post_data) {}
+      post_data(post_data) {
+  if (method == "POST") {

[clamy, 2016/05/30 16:40:43]

As mentioned in navigator_impl.cc I'm really not sure we want to add a check for
post data in POST navigation. And there should not be an if/else clause that
contains only DCHECKs.

[Łukasz Anforowicz, 2016/05/31 16:25:20]

Done.

+    if (navigation_type != FrameMsg_Navigate_Type::NORMAL) {
+      // No data is sent for reloads and/or history navigations - in these cases
+      // the body is already present in the renderer process (see |is_reload|
+      // and |is_history_navigation| branches in
+      // RenderFrameImpl::NavigateInternal).
+      DCHECK(!post_data);

[clamy, 2016/05/30 16:40:43]

This will break in PlzNavigate. We always send the POST data if any (we don't
use the aforementionned branches RenderFrameImpl::NavigateInternal.

[Łukasz Anforowicz, 2016/05/31 16:25:20]

Done (this branch of "if" statement was removed altogether).

+    } else {
+      // |post_data| should be present when "POST" HTTP method is used.
+      // TODO(lukasza): Reenable this after fixing https://crbug.com/613004.
+      // (currently post data is lost after some cross-site transfers).
+      // DCHECK(post_data);

[clamy, 2016/05/30 16:40:43]

Please don't add commented out code.

[Łukasz Anforowicz, 2016/05/31 16:25:20]

Done (this branch of "if" statement was removed altogether).

+    }
+  } else {
+    // |post_data| should be missing when HTTP method other than "POST" is used.
+    DCHECK(!post_data);
+  }
+}
 
 CommonNavigationParams::CommonNavigationParams(
     const CommonNavigationParams& other) = default;
 
 CommonNavigationParams::~CommonNavigationParams() {
 }
 
 BeginNavigationParams::BeginNavigationParams()
     : load_flags(0),
       has_user_gesture(false),
@@ skipping 108 matching lines @@
     const RequestNavigationParams& request_params)
     : common_params(common_params),
       start_params(start_params),
       request_params(request_params) {
 }
 
 NavigationParams::~NavigationParams() {
 }
 
 }  // namespace content