Forwarding POST body into renderer after a cross-site transfer.

content/common/navigation_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
 
 #include <stdint.h>
 
 #include <string>
 
+#include "base/memory/ref_counted.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
 #include "content/common/frame_message_enums.h"
+#include "content/common/resource_request_body.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/referrer.h"
 #include "content/public/common/request_context_type.h"
 #include "ui/base/page_transition_types.h"
 #include "url/gurl.h"
 
 namespace content {
 
 // The LoFi state which determines whether to add the Lo-Fi header.
 enum LoFiState {
@@ skipping 139 matching lines @@
 // architecture should go in StartNavigationParams.
 
 // Used by FrameMsg_Navigate. Holds the parameters needed by the renderer to
 // start a browser-initiated navigation besides those in CommonNavigationParams.
 // The difference with the RequestNavigationParams below is that they are only
 // used in the current architecture of navigation, and will not be used by
 // PlzNavigate.
 // PlzNavigate: These are not used.
 struct CONTENT_EXPORT StartNavigationParams {
   StartNavigationParams();
-  StartNavigationParams(
-      const std::string& extra_headers,
-      const std::vector<unsigned char>& browser_initiated_post_data,
+  StartNavigationParams(const std::string& extra_headers,
+                        const scoped_refptr<ResourceRequestBody>& post_data,
 #if defined(OS_ANDROID)
-      bool has_user_gesture,
+                        bool has_user_gesture,
 #endif
-      int transferred_request_child_id,
-      int transferred_request_request_id);
+                        int transferred_request_child_id,
+                        int transferred_request_request_id);
   StartNavigationParams(const StartNavigationParams& other);
   ~StartNavigationParams();
 
   // Extra headers (separated by \n) to send during the request.
   std::string extra_headers;
 
-  // If is_post is true, holds the post_data information from browser. Empty
-  // otherwise.
-  std::vector<unsigned char> browser_initiated_post_data;
+  // Body of HTTP POST request.
+  scoped_refptr<ResourceRequestBody> post_data;

[clamy, 2016/05/20 15:49:14]

Actually, I think this should be part of CommonNavigationParams. Right now, we
send it in the BeginNavigation IPC, the CommitNavigation IPC, and your CL adds
it to be used through the StartNavigationParams in the Navigate IPC. Let's have
it be a member of CommonNavigationParams (which is sent in all those IPCs), and
remove the extra member of FramehostMsg_BeginNavigation and
FrameMsg_CommitNavigation.

[Łukasz Anforowicz, 2016/05/20 22:18:47]

Done.  I've done that initially here, but then decided to move this refactoring
to a separate CL: https://codereview.chromium.org/1999943002/

 
 #if defined(OS_ANDROID)
   bool has_user_gesture;
 #endif
 
   // The following two members identify a previous request that has been
   // created before this navigation is being transferred to a new render view.
   // This serves the purpose of recycling the old request.
   // Unless this refers to a transferred navigation, these values are -1 and -1.
   int transferred_request_child_id;
@@ skipping 120 matching lines @@
   ~NavigationParams();
 
   CommonNavigationParams common_params;
   StartNavigationParams start_params;
   RequestNavigationParams request_params;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_NAVIGATION_PARAMS_H_