Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956383002: gclient: explicitly set checkout cwd for runhooks (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
Reviewers:
dsansome
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

gclient: explicitly set checkout cwd for runhooks BUG=chromium:596887 R=dsansome@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M recipe_modules/gclient/api.py View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/gclient/example.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/gclient/example.expected/revision.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/gclient/example.expected/tryserver.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dsansome
lgtm
4 years, 7 months ago (2016-05-09 14:15:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956383002/1
4 years, 7 months ago (2016-05-09 14:22:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/433)
4 years, 7 months ago (2016-05-09 14:25:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956383002/1
4 years, 7 months ago (2016-05-09 14:27:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/435)
4 years, 7 months ago (2016-05-09 14:30:31 UTC) #10
Paweł Hajdan Jr.
4 years, 7 months ago (2016-05-09 14:38:12 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 300503.

Powered by Google App Engine
This is Rietveld 408576698