Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 195633002: [CSS Shapes] Add performance tests for SVG shape with shape-margin (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
CC:
blink-reviews, Zoltan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] Add performance tests for SVG shape with shape-margin Test taken from https://bugs.webkit.org/show_bug.cgi?id=129930 BUG=349093 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168939

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A + PerformanceTests/Layout/Shapes/ShapeOutsideSVGWithMargin.html View 1 chunk +1 line, -1 line 0 comments Download
A PerformanceTests/Layout/Shapes/resources/shape.svg View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
Simple copy over patch from WebKit. WebKit bugzilla/trac seems down but I grabbed it from ...
6 years, 9 months ago (2014-03-11 18:49:06 UTC) #1
leviw_travelin_and_unemployed
Cool! LGTM. https://codereview.chromium.org/195633002/diff/1/PerformanceTests/Layout/Shapes/resources/shape.svg File PerformanceTests/Layout/Shapes/resources/shape.svg (right): https://codereview.chromium.org/195633002/diff/1/PerformanceTests/Layout/Shapes/resources/shape.svg#newcode2 PerformanceTests/Layout/Shapes/resources/shape.svg:2: <!-- Generator: Adobe Illustrator 17.0.0, SVG Export ...
6 years, 9 months ago (2014-03-11 18:51:47 UTC) #2
rwlbuis
On 2014/03/11 18:51:47, Levi wrote: > Cool! LGTM. > > https://codereview.chromium.org/195633002/diff/1/PerformanceTests/Layout/Shapes/resources/shape.svg > File PerformanceTests/Layout/Shapes/resources/shape.svg (right): ...
6 years, 9 months ago (2014-03-11 18:57:03 UTC) #3
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-11 18:58:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/195633002/20001
6 years, 9 months ago (2014-03-11 18:59:11 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 19:00:21 UTC) #6
Message was sent while issue was closed.
Change committed as 168939

Powered by Google App Engine
This is Rietveld 408576698