Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/ime/xkeyboard.cc

Issue 195623002: roll clang 198389:202554 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cros Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | third_party/libxml/libxml.gyp » ('j') | tools/clang/scripts/plugin_flags.sh » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/ime/xkeyboard.cc
diff --git a/chromeos/ime/xkeyboard.cc b/chromeos/ime/xkeyboard.cc
index 7714e20b241ed9dc6480628dcc211be8c0552e6f..25d78c30bedaa532c8143781afeb82aa5d864f9b 100644
--- a/chromeos/ime/xkeyboard.cc
+++ b/chromeos/ime/xkeyboard.cc
@@ -153,7 +153,7 @@ unsigned int XKeyboardImpl::GetNumLockMask() {
if (!xkb_desc)
return kBadMask;
- if (xkb_desc->dpy && xkb_desc->names && xkb_desc->names->vmods) {
+ if (xkb_desc->dpy && xkb_desc->names /*TODO && xkb_desc->names->vmods*/) {
const std::string string_to_find(kNumLockVirtualModifierString);
for (size_t i = 0; i < XkbNumVirtualMods; ++i) {
const unsigned int virtual_mod_mask = 1U << i;
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | third_party/libxml/libxml.gyp » ('j') | tools/clang/scripts/plugin_flags.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698