Chromium Code Reviews Chromium Code Reviews
Issue 1956213002:
Convert track-webvtt-tc[000-002] tests to testharness.js (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc002-bom.html |
| diff --git a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc002-bom.html b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc002-bom.html |
| index e17de308b67a0107347e764a87ec495fc88391f1..1df6c86e00d77ad102583f12b321ecabf3d0ba08 100644 |
| --- a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc002-bom.html |
| +++ b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc002-bom.html |
| @@ -1,50 +1,28 @@ |
| <!DOCTYPE html> |
| -<html> |
| - <head> |
| - <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> |
| +<title>Tests that the parser properly ignores a UTF-8 BOM character at the beginning of a file and all other cues are properly parsed.</title> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<video> |
| + <track src="captions-webvtt/tc002-bom.vtt" default> |
| +</video> |
| +<script> |
| +async_test(function(t) { |
| + var track = document.querySelector("track"); |
| - <script src=../media-file.js></script> |
| - <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956 |
| - (Please avoid writing new tests using video-test.js) --> |
| - <script src=../video-test.js></script> |
| - <script> |
| + track.onload = t.step_func_done(function() { |
| + var idValues = ["1", "2"]; |
| + var startTimeValues = [0, 31]; |
| + var endTimeValues = [30.5, 1200.5]; |
| + var textValues = ["Bear is Coming!!!!!", "I said Bear is coming!!!!"]; |
| - function trackLoaded() |
| - { |
| - findMediaElement(); |
| - var expected = |
| - { |
| - length : 2, |
| - tests: |
| - [ |
| - { |
| - property : "id", |
| - values : [1, 2], |
| - }, |
| - { |
| - property : "startTime", |
| - values : [0.0, 31.0], |
| - }, |
| - { |
| - property : "endTime", |
| - values : [30.5, 1200.5], |
| - }, |
| - { |
| - property : "text", |
| - values : ["Bear is Coming!!!!!", "I said Bear is coming!!!!"], |
| - }, |
| - ], |
| - }; |
| - testCues(0, expected); |
| - |
| - endTest(); |
| - } |
| - </script> |
| - </head> |
| - <body> |
| - <p>Tests that the parser properly ignores a UTF-8 BOM character at the beginning of a file and all other cues are properly parsed.</p> |
| - <video> |
| - <track src="captions-webvtt/tc002-bom.vtt" onload="trackLoaded()" default> |
| - </video> |
| - </body> |
| -</html> |
| + var cues = track.track.cues; |
| + assert_equals(cues.length, 2); |
| + for (var i = 0; i < cues.length; i++) { |
| + assert_equals(cues[i].id, idValues[i]); |
| + assert_equals(cues[i].startTime, startTimeValues[i]); |
| + assert_equals(cues[i].endTime, endTimeValues[i]); |
| + assert_equals(cues[i].text, textValues[i]); |
|
mlamouri (slow - plz ping)
2016/05/10 09:14:39
I think it would make sense to have a helper file
Srirama
2016/05/10 09:32:50
Agreed, makes sense. Even enableAllTextTracks() is
Srirama
2016/05/11 10:18:21
Done.
|
| + } |
| + }); |
| +}); |
| +</script> |
