Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 19562002: Add BYTES_PER_ELEMENT property to constructors of typed arrays. (Closed)

Created:
7 years, 5 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add BYTES_PER_ELEMENT property to constructors of typed arrays. ES6 does not prescribe it, but both Blink and Firefox have it. Also does a small rename of parameter in test. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M src/typedarray.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 5 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL. Cut 1001.
7 years, 5 months ago (2013-07-17 11:07:30 UTC) #1
Benedikt Meurer
lgtm
7 years, 5 months ago (2013-07-17 11:15:23 UTC) #2
Dmitry Lomov (no reviews)
7 years, 5 months ago (2013-07-17 11:16:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698