Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956093002: mus: Move event_matcher_util.h/cc into components/mus/common (Closed)

Created:
4 years, 7 months ago by James Cook
Modified:
4 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Move event_matcher_util.h/cc into components/mus/common This will allow me to use it from components/mus/ws for internal debug accelerators. BUG=none TEST=compiles Committed: https://crrev.com/3a6fb84e38bb306ac3ef13b4e13195e6ac41b7f8 Cr-Commit-Position: refs/heads/master@{#392214}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -63 lines) Patch
M components/mus/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/mus/common/event_matcher_util.h View 2 chunks +6 lines, -4 lines 0 comments Download
A + components/mus/common/event_matcher_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/mus/public/cpp/event_matcher_util.h View 1 chunk +0 lines, -20 lines 0 comments Download
D components/mus/public/cpp/lib/event_matcher_util.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/DEPS View 1 1 chunk +1 line, -2 lines 0 comments Download
M mash/browser_driver/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/accelerator_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1953193002 Patch 60001
Issue 1953193002 Patch 80001

Messages

Total messages: 10 (4 generated)
James Cook
msw, please take a look I need this for my debug accelerator patch.
4 years, 7 months ago (2016-05-06 21:53:49 UTC) #2
msw
lgtm with nits https://codereview.chromium.org/1956093002/diff/1/mash/DEPS File mash/DEPS (right): https://codereview.chromium.org/1956093002/diff/1/mash/DEPS#newcode2 mash/DEPS:2: "+components/mus/common/event_matcher_util.h", nit: allow any "+components/mus/common"? https://codereview.chromium.org/1956093002/diff/1/mash/browser_driver/BUILD.gn ...
4 years, 7 months ago (2016-05-06 22:08:34 UTC) #3
James Cook
https://codereview.chromium.org/1956093002/diff/1/mash/DEPS File mash/DEPS (right): https://codereview.chromium.org/1956093002/diff/1/mash/DEPS#newcode2 mash/DEPS:2: "+components/mus/common/event_matcher_util.h", On 2016/05/06 22:08:33, msw wrote: > nit: allow ...
4 years, 7 months ago (2016-05-06 22:57:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956093002/40001
4 years, 7 months ago (2016-05-06 23:05:19 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-07 00:20:01 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 00:21:39 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3a6fb84e38bb306ac3ef13b4e13195e6ac41b7f8
Cr-Commit-Position: refs/heads/master@{#392214}

Powered by Google App Engine
This is Rietveld 408576698