Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1956073003: Only accept the hermetic toolchain license if newer. (Closed)

Created:
4 years, 7 months ago by justincohen
Modified:
4 years, 7 months ago
Reviewers:
erikchen
CC:
chromium-reviews, smut, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only accept the hermetic toolchain license if newer. Accepting an older license will break newer toolchains. Check if a bot's last agreed to toolchain is newer. If it's older, accept the hermetic toolchain. BUG= Committed: https://crrev.com/10dc9038e9e0e42efa7a53c4f6857a6749ceea0b Cr-Commit-Position: refs/heads/master@{#392356}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Only accept the license if necessary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
M build/mac_toolchain.py View 1 2 chunks +48 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
justincohen
Not sure why this happens with passwordless sudo, but I can reproduce this locally when ...
4 years, 7 months ago (2016-05-07 21:30:03 UTC) #2
erikchen
https://codereview.chromium.org/1956073003/diff/1/build/mac_toolchain.py File build/mac_toolchain.py (right): https://codereview.chromium.org/1956073003/diff/1/build/mac_toolchain.py#newcode113 build/mac_toolchain.py:113: # to do just that. Re-accept the |old_path| toolchain ...
4 years, 7 months ago (2016-05-08 17:56:26 UTC) #3
justincohen
https://macops.ca/deploying-xcode-the-trick-with-accepting-license-agreements was helpful, looks the script should only accept the license if it's GM or ...
4 years, 7 months ago (2016-05-08 18:34:33 UTC) #4
justincohen
ptal!
4 years, 7 months ago (2016-05-08 20:00:48 UTC) #6
erikchen
thanks! lgtm
4 years, 7 months ago (2016-05-09 16:09:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956073003/20001
4 years, 7 months ago (2016-05-09 17:06:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 17:47:34 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:50:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10dc9038e9e0e42efa7a53c4f6857a6749ceea0b
Cr-Commit-Position: refs/heads/master@{#392356}

Powered by Google App Engine
This is Rietveld 408576698