Only accept the hermetic toolchain license if newer.

Only accept the hermetic toolchain license if newer.

Accepting an older license will break newer toolchains.  Check if a bot's
last agreed to toolchain is newer.  If it's older, accept the hermetic toolchain.

BUG=

Committed: https://crrev.com/10dc9038e9e0e42efa7a53c4f6857a6749ceea0b
Cr-Commit-Position: refs/heads/master@{#392356}

[justincohen, 2016-05-07 21:30:02]

justincohen@chromium.org changed reviewers:
+ erikchen@chromium.org

[justincohen, 2016-05-07 21:30:03]

Not sure why this happens with passwordless sudo, but I can reproduce this
locally when I add `justincohen ALL=(ALL) NOPASSWD: ALL` to sudoers.  This is
needed for bots that share builds between hermetic and non-hermetic builds.

PTAL!

[erikchen, 2016-05-08 17:56:26]

https://codereview.chromium.org/1956073003/diff/1/build/mac_toolchain.py
File build/mac_toolchain.py (right):

https://codereview.chromium.org/1956073003/diff/1/build/mac_toolchain.py#newc...
build/mac_toolchain.py:113: # to do just that.  Re-accept the |old_path|
toolchain just incase.
accepting the old license doesn't unaccept the new license? Given the symmetry,
I don't see how this can be possible unless there's a third factor that we're
not taking into account. Could you do some more digging?

[justincohen, 2016-05-08 18:34:33]

https://macops.ca/deploying-xcode-the-trick-with-accepting-license-agreements
was helpful, looks the script should only accept the license if it's GM or beta
version is greater than the value stored in
/Library/Preferences/com.apple.dt.Xcode.plist

[justincohen, 2016-05-08 20:00:37]

Description was changed from

==========
Re-accept old toolchain license after accepting hermetic license.

Something related to using passwordless sudo is unaccepting the old toolchain
license after accepting the hermetic build license.  This will break bots that
share hermetic and non-hermetic builds.  Re-accepting the main toolchain fixes
this.

BUG=
==========

to

==========
Only accept the hermetic toolchain license if newer.

Accepting an older license will break newer toolchains.  Check if a bot's
last agreed to toolchain is newer.  If it's older, accept the hermetic
toolchain.

BUG=
==========

[justincohen, 2016-05-08 20:00:48]

ptal!

[erikchen, 2016-05-09 16:09:45]

thanks! lgtm

[justincohen, 2016-05-09 17:05:30]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-05-09 17:06:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956073003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956073003/20001

[commit-bot: I haz the power, 2016-05-09 17:47:33]

Description was changed from

==========
Only accept the hermetic toolchain license if newer.

Accepting an older license will break newer toolchains.  Check if a bot's
last agreed to toolchain is newer.  If it's older, accept the hermetic
toolchain.

BUG=
==========

to

==========
Only accept the hermetic toolchain license if newer.

Accepting an older license will break newer toolchains.  Check if a bot's
last agreed to toolchain is newer.  If it's older, accept the hermetic
toolchain.

BUG=
==========

[commit-bot: I haz the power, 2016-05-09 17:47:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-09 17:50:19]

Description was changed from

==========
Only accept the hermetic toolchain license if newer.

Accepting an older license will break newer toolchains.  Check if a bot's
last agreed to toolchain is newer.  If it's older, accept the hermetic
toolchain.

BUG=
==========

to

==========
Only accept the hermetic toolchain license if newer.

Accepting an older license will break newer toolchains.  Check if a bot's
last agreed to toolchain is newer.  If it's older, accept the hermetic
toolchain.

BUG=

Committed: https://crrev.com/10dc9038e9e0e42efa7a53c4f6857a6749ceea0b
Cr-Commit-Position: refs/heads/master@{#392356}
==========

[commit-bot: I haz the power, 2016-05-09 17:50:20]

Patchset 2 (id:??) landed as
https://crrev.com/10dc9038e9e0e42efa7a53c4f6857a6749ceea0b
Cr-Commit-Position: refs/heads/master@{#392356}