[libfuzzer] flatbuffers verifier fuzzer.

[libfuzzer] flatbuffers verifier fuzzer.

BUG=539572
Committed: https://crrev.com/6b48b42dadbe5dbe8e6de741c4b76863f0636d5d
Cr-Commit-Position: refs/heads/master@{#393265}

[aizatsky, 2016-05-06 18:05:21]

aizatsky@chromium.org changed reviewers:
+ battre@chromium.org, engedy@chromium.org, ochang@chromium.org

[Oliver Chang, 2016-05-06 18:21:57]

where's flatbuffers_verifier_fuzzer.cc ?

[aizatsky, 2016-05-06 18:22:36]

On 2016/05/06 at 18:21:57, ochang wrote:
> where's flatbuffers_verifier_fuzzer.cc ?

Ooops. Done.

[Oliver Chang, 2016-05-06 18:26:25]

lgtm, but not familiar with flatbuffers

[engedy, 2016-05-06 19:09:21]

LGTM, thanks!

[battre, 2016-05-06 19:32:45]

Should the fuzzer be initialized with a valid flatbuffer?

[aizatsky, 2016-05-06 20:06:46]

On 2016/05/06 at 19:32:45, battre wrote:
> Should the fuzzer be initialized with a valid flatbuffer?

No, why? Usually fuzzers test invalid outputs.

I also added a seed with valid proto, to bootstrap the corpus.

[aizatsky, 2016-05-06 20:07:03]

The CQ bit was checked by aizatsky@chromium.org

[aizatsky, 2016-05-06 20:07:03]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org,
engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/1955993002/#ps40001
(title: "added seed")

[commit-bot: I haz the power, 2016-05-06 20:07:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955993002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955993002/40001

[commit-bot: I haz the power, 2016-05-06 20:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 20:41:42]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aizatsky, 2016-05-08 20:11:31]

The CQ bit was checked by aizatsky@chromium.org

[commit-bot: I haz the power, 2016-05-08 20:11:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955993002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955993002/40001

[aizatsky, 2016-05-08 20:13:17]

I'm pretty sure this trybots error happens because flatbuffer GN generator isn't
tracking dependencies.

Dominic, Balazs, have you seen anything like this?

[commit-bot: I haz the power, 2016-05-08 20:30:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-08 20:30:55]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[battre, 2016-05-09 07:19:55]

On 2016/05/06 20:06:46, aizatsky wrote:
> On 2016/05/06 at 19:32:45, battre wrote:
> > Should the fuzzer be initialized with a valid flatbuffer?
> 
> No, why? Usually fuzzers test invalid outputs.
> 
> I also added a seed with valid proto, to bootstrap the corpus.

Thanks. I think that seeding with a valid proto will help to increase code
coverage because I expect it to be hard for the fuzzer to generate a buffer that
does not already fail in the very early stages.

[battre, 2016-05-09 07:20:30]

On 2016/05/06 20:06:46, aizatsky wrote:
> On 2016/05/06 at 19:32:45, battre wrote:
> > Should the fuzzer be initialized with a valid flatbuffer?
> 
> No, why? Usually fuzzers test invalid outputs.
> 
> I also added a seed with valid proto, to bootstrap the corpus.

https://codereview.chromium.org/1958033002/ should fix it.

Best regards,
Dominic

[battre, 2016-05-09 07:21:06]

On 2016/05/09 07:20:30, battre wrote:
> On 2016/05/06 20:06:46, aizatsky wrote:
> > On 2016/05/06 at 19:32:45, battre wrote:
> > > Should the fuzzer be initialized with a valid flatbuffer?
> > 
> > No, why? Usually fuzzers test invalid outputs.
> > 
> > I also added a seed with valid proto, to bootstrap the corpus.
> 
> https://codereview.chromium.org/1958033002/ should fix it.
> 
> Best regards,
> Dominic

Sorry, this should go below your message "I'm pretty sure this trybots error
happens because flatbuffer GN generator isn't
tracking dependencies."

[battre, 2016-05-12 15:25:07]

The CQ bit was checked by battre@chromium.org

[commit-bot: I haz the power, 2016-05-12 15:25:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955993002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955993002/40001

[commit-bot: I haz the power, 2016-05-12 16:20:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-12 16:23:17]

Description was changed from

==========
[libfuzzer] flatbuffers verifier fuzzer.

BUG=539572
==========

to

==========
[libfuzzer] flatbuffers verifier fuzzer.

BUG=539572

Committed: https://crrev.com/6b48b42dadbe5dbe8e6de741c4b76863f0636d5d
Cr-Commit-Position: refs/heads/master@{#393265}
==========

[commit-bot: I haz the power, 2016-05-12 16:23:18]

Patchset 3 (id:??) landed as
https://crrev.com/6b48b42dadbe5dbe8e6de741c4b76863f0636d5d
Cr-Commit-Position: refs/heads/master@{#393265}