Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1955943002: Fix bug with runtime-call-stats timers (Closed)

Created:
4 years, 7 months ago by nickie
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bug with runtime-call-stats timers RuntimeCallTimers were not properly stopped and this made a DCHECK in the Debug version fail. R=cbruni@chromium.org BUG= LOG=N Committed: https://crrev.com/a156a05101bb8822d12c5f21fbea2f00854ed165 Cr-Commit-Position: refs/heads/master@{#36097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nickie
4 years, 7 months ago (2016-05-06 16:35:44 UTC) #1
Camillo Bruni
lgtm
4 years, 7 months ago (2016-05-09 07:03:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955943002/1
4 years, 7 months ago (2016-05-09 07:32:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 08:04:42 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 08:04:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a156a05101bb8822d12c5f21fbea2f00854ed165
Cr-Commit-Position: refs/heads/master@{#36097}

Powered by Google App Engine
This is Rietveld 408576698