Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1955913002: Fix for Ubuntu compile warning (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Trying another way #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/core/SkMaskCache.cpp View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jvanverth1
Fix for one of the errors.
4 years, 7 months ago (2016-05-06 16:05:08 UTC) #3
robertphillips
lgtm. A meta-question is why aren't we just storing just the rects in the key?
4 years, 7 months ago (2016-05-06 16:12:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955913002/20001
4 years, 7 months ago (2016-05-06 16:14:42 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 16:33:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/73e81abd5e87a6630a2e2725abf13e11af4c8792

Powered by Google App Engine
This is Rietveld 408576698