Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3138)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java

Issue 1955903003: Extend progress bar animation start time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@adjust-colors
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java
index 7b26b7f9af3dcd3168686fb7bc60394801d3eb1f..9c4c0418a3b15d89002ad8f48165beca1feed45c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java
@@ -99,13 +99,14 @@ public class ToolbarProgressBarAnimatingView extends ImageView {
slowAnimation.addUpdateListener(mListener);
mAnimatorSet.playSequentially(fastAnimation, slowAnimation);
- mAnimatorSet.setStartDelay(ANIMATION_DELAY_MS);
slowAnimation.addListener(new AnimatorListenerAdapter() {
@Override
public void onAnimationEnd(Animator a) {
// Replay the animation if it has not been canceled.
if (mIsCanceled) return;
+ // Repeats of the animation should have a start delay.
+ mAnimatorSet.setStartDelay(ANIMATION_DELAY_MS);
mAnimatorSet.start();
}
});
@@ -117,10 +118,14 @@ public class ToolbarProgressBarAnimatingView extends ImageView {
public void startAnimation() {
mIsCanceled = false;
if (!mAnimatorSet.isStarted()) {
+ // Set the initial start delay to 0ms so it starts immediately.
+ mAnimatorSet.setStartDelay(0);
+
// Reset position.
setScaleX(0.0f);
setTranslationX(0.0f);
mAnimatorSet.start();
+
// Fade in to look nice on sites that trigger many loads that end quickly.
animate().alpha(1.0f)
.setDuration(500)
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698