Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: media/renderers/audio_renderer_impl_unittest.cc

Issue 1955843002: Move Renderer permanent callbacks into RendererClient interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/renderers/audio_renderer_impl.cc ('k') | media/renderers/renderer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/audio_renderer_impl_unittest.cc
diff --git a/media/renderers/audio_renderer_impl_unittest.cc b/media/renderers/audio_renderer_impl_unittest.cc
index d930103864f3f8c3d8f65d6e0b034915e6864c05..12b2c5dde5979bf9d0b873ca6e8ac919a25110f6 100644
--- a/media/renderers/audio_renderer_impl_unittest.cc
+++ b/media/renderers/audio_renderer_impl_unittest.cc
@@ -65,7 +65,7 @@ ACTION_P(EnterPendingDecoderInitStateAction, test) {
test->EnterPendingDecoderInitState(arg2);
}
-class AudioRendererImplTest : public ::testing::Test {
+class AudioRendererImplTest : public ::testing::Test, public RendererClient {
public:
// Give the decoder some non-garbage media properties.
AudioRendererImplTest()
@@ -116,26 +116,21 @@ class AudioRendererImplTest : public ::testing::Test {
.WillOnce(DoAll(SaveArg<3>(&output_cb_), RunCallback<2>(false)));
}
- void OnStatistics(const PipelineStatistics& stats) {
+ // RendererClient implementation.
+ MOCK_METHOD1(OnError, void(PipelineStatus));
+ void OnEnded() override {
+ CHECK(!ended_);
+ ended_ = true;
+ }
+ void OnStatisticsUpdate(const PipelineStatistics& stats) override {
last_statistics_.audio_memory_usage += stats.audio_memory_usage;
}
-
MOCK_METHOD1(OnBufferingStateChange, void(BufferingState));
- MOCK_METHOD1(OnError, void(PipelineStatus));
MOCK_METHOD0(OnWaitingForDecryptionKey, void(void));
void InitializeRenderer(const PipelineStatusCB& pipeline_status_cb) {
EXPECT_CALL(*this, OnWaitingForDecryptionKey()).Times(0);
- renderer_->Initialize(
- &demuxer_stream_, pipeline_status_cb, nullptr,
- base::Bind(&AudioRendererImplTest::OnStatistics,
- base::Unretained(this)),
- base::Bind(&AudioRendererImplTest::OnBufferingStateChange,
- base::Unretained(this)),
- base::Bind(&AudioRendererImplTest::OnEnded, base::Unretained(this)),
- base::Bind(&AudioRendererImplTest::OnError, base::Unretained(this)),
- base::Bind(&AudioRendererImplTest::OnWaitingForDecryptionKey,
- base::Unretained(this)));
+ renderer_->Initialize(&demuxer_stream_, nullptr, this, pipeline_status_cb);
}
void Initialize() {
@@ -414,11 +409,6 @@ class AudioRendererImplTest : public ::testing::Test {
base::RunLoop().RunUntilIdle();
}
- void OnEnded() {
- CHECK(!ended_);
- ended_ = true;
- }
-
MockDemuxerStream demuxer_stream_;
MockAudioDecoder* decoder_;
« no previous file with comments | « media/renderers/audio_renderer_impl.cc ('k') | media/renderers/renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698