Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: media/base/renderer.h

Issue 1955843002: Move Renderer permanent callbacks into RendererClient interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline_impl_unittest.cc ('k') | media/base/renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/renderer.h
diff --git a/media/base/renderer.h b/media/base/renderer.h
index 89e349a9350d1c44564690a84bdc2391589e78d2..fae6115f3c8ee619eb1efa3da7c4195b40244cd3 100644
--- a/media/base/renderer.h
+++ b/media/base/renderer.h
@@ -17,6 +17,7 @@
namespace media {
class DemuxerStreamProvider;
+class RendererClient;
class VideoFrame;
class MEDIA_EXPORT Renderer {
@@ -27,27 +28,13 @@ class MEDIA_EXPORT Renderer {
virtual ~Renderer();
// Initializes the Renderer with |demuxer_stream_provider|, executing
- // |init_cb| upon completion. If initialization fails, only |init_cb| (not
- // |error_cb|) should be called. |demuxer_stream_provider| must be valid for
+ // |init_cb| upon completion. |demuxer_stream_provider| must be valid for
// the lifetime of the Renderer object. |init_cb| must only be run after this
// method has returned. Firing |init_cb| may result in the immediate
// destruction of the caller, so it must be run only prior to returning.
- //
- // Permanent callbacks:
- // - |statistics_cb|: Executed periodically with rendering statistics.
- // - |buffering_state_cb|: Executed when buffering state is changed.
- // - |ended_cb|: Executed when rendering has reached the end of stream.
- // - |error_cb|: Executed if any error was encountered after initialization.
- // - |waiting_for_decryption_key_cb|: Executed whenever the key needed to
- // decrypt the stream is not available.
- virtual void Initialize(
- DemuxerStreamProvider* demuxer_stream_provider,
- const PipelineStatusCB& init_cb,
- const StatisticsCB& statistics_cb,
- const BufferingStateCB& buffering_state_cb,
- const base::Closure& ended_cb,
- const PipelineStatusCB& error_cb,
- const base::Closure& waiting_for_decryption_key_cb) = 0;
+ virtual void Initialize(DemuxerStreamProvider* demuxer_stream_provider,
+ RendererClient* client,
+ const PipelineStatusCB& init_cb) = 0;
// Associates the |cdm_context| with this Renderer for decryption (and
// decoding) of media data, then fires |cdm_attached_cb| with the result.
« no previous file with comments | « media/base/pipeline_impl_unittest.cc ('k') | media/base/renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698