Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chromecast/renderer/media/cma_renderer.h

Issue 1955843002: Move Renderer permanent callbacks into RendererClient interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/media/cast_renderer.cc ('k') | chromecast/renderer/media/cma_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/renderer/media/cma_renderer.h
diff --git a/chromecast/renderer/media/cma_renderer.h b/chromecast/renderer/media/cma_renderer.h
index c2ae45efff2d4b256656f5f6958c23f0d4eea1d6..1132f6460f44ff83c928e2a96725c0e9a15559c8 100644
--- a/chromecast/renderer/media/cma_renderer.h
+++ b/chromecast/renderer/media/cma_renderer.h
@@ -45,12 +45,8 @@ class CmaRenderer : public ::media::Renderer {
// ::media::Renderer implementation:
void Initialize(::media::DemuxerStreamProvider* demuxer_stream_provider,
- const ::media::PipelineStatusCB& init_cb,
- const ::media::StatisticsCB& statistics_cb,
- const ::media::BufferingStateCB& buffering_state_cb,
- const base::Closure& ended_cb,
- const ::media::PipelineStatusCB& error_cb,
- const base::Closure& waiting_for_decryption_key_cb) override;
+ ::media::RendererClient* client,
+ const ::media::PipelineStatusCB& init_cb) override;
void Flush(const base::Closure& flush_cb) override;
void StartPlayingFrom(base::TimeDelta time) override;
void SetPlaybackRate(double playback_rate) override;
@@ -110,13 +106,9 @@ class CmaRenderer : public ::media::Renderer {
::media::DemuxerStreamProvider* demuxer_stream_provider_;
// Set of callbacks.
+ ::media::RendererClient* client_;
::media::PipelineStatusCB init_cb_;
- ::media::StatisticsCB statistics_cb_;
- base::Closure ended_cb_;
- ::media::PipelineStatusCB error_cb_;
- ::media::BufferingStateCB buffering_state_cb_;
base::Closure flush_cb_;
- base::Closure waiting_for_decryption_key_cb_;
// Renderer state.
// Used mostly for checking that transitions are correct.
« no previous file with comments | « chromecast/browser/media/cast_renderer.cc ('k') | chromecast/renderer/media/cma_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698