ui/gl/android/surface_texture_tracker.cc - Issue 195583003: Add initial GpuMemoryBufferSurfaceTexture implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gl/android/surface_texture_tracker.cc

Issue 195583003: Add initial GpuMemoryBufferSurfaceTexture implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/gl/android/surface_texture_tracker.h"

	6

	7 namespace gfx {

	8 namespace {

	9 SurfaceTextureTracker* g_instance = NULL;
	epennerAtGoogle 2014/03/12 00:45:06 Same on this one. Can you use LazyInstance or comm Same on this one. Can you use LazyInstance or comment why initialization races are impossible? reveman 2014/03/12 16:07:06 Same answer. Show quoted text On 2014/03/12 00:45:06, epennerAtGoogle wrote: > Same on this one. Can you use LazyInstance or comment why initialization races > are impossible? Same answer.
	10 } // namespace

	11

	12 // static

	13 SurfaceTextureTracker* SurfaceTextureTracker::GetInstance() {
	epennerAtGoogle 2014/03/12 00:45:06 This is a lot better than an 'extern' but not _hug This is a lot better than an 'extern' but not _huge_ amount better ;). What I'm worried about is this becoming an extra item that prevents us from using out-of-proc GPU which otherwise just has one blocking issue IIUC. I suppose we can just disable this feature if we do that, so I'm okay with it for now. Sievers@, what's your thoughts? reveman 2014/03/12 16:07:06 I'd like to get this working with out-of-proc GPU Show quoted text On 2014/03/12 00:45:06, epennerAtGoogle wrote: > This is a lot better than an 'extern' but not _huge_ amount better ;). What I'm > worried about is this becoming an extra item that prevents us from using > out-of-proc GPU which otherwise just has one blocking issue IIUC. > > I suppose we can just disable this feature if we do that, so I'm okay with it > for now. Sievers@, what's your thoughts? I'd like to get this working with out-of-proc GPU asap but thought it'd be better to land this first and do that as a follow up. The idea is that none of this would change in out-of-proc GPU mode. This instance would just be set to a different implementation by the GPU service code. epennerAtGoogle 2014/03/12 19:46:28 If sievers@ is okay with it then no worries here. If sievers@ is okay with it then no worries here.
	14 DCHECK(g_instance);

	15 return g_instance;

	16 }

	17

	18 // static

	19 void SurfaceTextureTracker::InitInstance(SurfaceTextureTracker* tracker) {

	20 DCHECK(!g_instance \|\| !tracker);

	21 g_instance = tracker;

	22 }

	23

	24 } // namespace gfx

OLD	NEW

« ui/gfx/gpu_memory_buffer.h ('K') | « ui/gl/android/surface_texture_tracker.h ('k') | ui/gl/gl.gyp » ('j') | ui/gl/gl_image_surface_texture.cc » ('J')