Add initial GpuMemoryBufferSurfaceTexture implementation.

content/common/gpu/gpu_command_buffer_stub.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/hash.h"
 #include "base/memory/shared_memory.h"
@@ skipping 852 matching lines @@
   }
 }
 
 void GpuCommandBufferStub::OnRegisterGpuMemoryBuffer(
     int32 id,
     gfx::GpuMemoryBufferHandle gpu_memory_buffer,
     uint32 width,
     uint32 height,
     uint32 internalformat) {
   TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnRegisterGpuMemoryBuffer");
+#if defined(OS_ANDROID)
+  // Verify that renderer is not trying to use a surface texture it doesn't own.
+  if (gpu_memory_buffer.type == gfx::SURFACE_TEXTURE_BUFFER &&
+      gpu_memory_buffer.surface_texture_id.secondary_id !=
+          channel()->renderer_pid()) {

[piman, 2014/03/27 01:07:25]

nit: rather than the PID, use the channel's client_id_ (which is the renderer
process id, render_process_id_ in RenderMessageFilter or GpuMessageFilter), it's
more portable and keeps the separation independent of how renderer processes are
used by various compositors.
Also, PIDs get reused (small namespace), whereas render_process_id_ don't.

[reveman, 2014/03/27 14:48:11]

Oh, I didn't know that we shared this id the GPU service. That's great! Cleans
up a lot of the Java code and will make out-of-process GPU support easier to
implement as we don't have to worry about id reuse.

+    LOG(ERROR) << "Illegal surface texture ID for renderer.";
+    return;
+  }
+#endif
   if (gpu_control_) {
     gpu_control_->RegisterGpuMemoryBuffer(id,
                                           gpu_memory_buffer,
                                           width,
                                           height,
                                           internalformat);
   }
 }
 
 void GpuCommandBufferStub::OnDestroyGpuMemoryBuffer(int32 id) {
@@ skipping 93 matching lines @@
   if (decoder_)
     decoder_->LoseContext(GL_UNKNOWN_CONTEXT_RESET_ARB);
   command_buffer_->SetParseError(gpu::error::kLostContext);
 }
 
 uint64 GpuCommandBufferStub::GetMemoryUsage() const {
   return GetMemoryManager()->GetClientMemoryUsage(this);
 }
 
 }  // namespace content