Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1955823002: Fade the peeking card content is as the user is scrolling down (Closed)

Created:
4 years, 7 months ago by mcwilliams
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fade the peeking card content is as the user is scrolling down Video: Nexus 6 -- https://drive.google.com/open?id=0B1IgAIJ9cgizbHFrdG9mclBNN2s Nexus 5 -- https://drive.google.com/open?id=0B1IgAIJ9cgizTWd0LVRtalVBdFU BUG=609750 Committed: https://crrev.com/9d928a706740ddcdc95163a97b7a1315f61472ef Cr-Commit-Position: refs/heads/master@{#392039}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mcwilliams
4 years, 7 months ago (2016-05-06 10:32:52 UTC) #2
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-06 11:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955823002/20001
4 years, 7 months ago (2016-05-06 11:23:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 11:57:11 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 11:58:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d928a706740ddcdc95163a97b7a1315f61472ef
Cr-Commit-Position: refs/heads/master@{#392039}

Powered by Google App Engine
This is Rietveld 408576698