Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4091)

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 1955813002: Create TextViewWithLeading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml
diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
index 4e92dd5204aae3919b8f5a83cf63fef5726ce669..273c26372fcd46f0a85aefd9256e2bfa415202ec 100644
--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
@@ -5,13 +5,14 @@
<RelativeLayout
xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:chrome="http://schemas.android.com/apk/res-auto"
android:id="@+id/snippets_card_view"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="16dp"
android:background="@color/snippets_background_color">
- <TextView
+ <org.chromium.ui.widget.TextViewWithLeading
android:id="@+id/article_headline"
android:layout_width="match_parent"
android:layout_height="wrap_content"
@@ -20,20 +21,22 @@
android:maxLines="2"
android:ellipsize="end"
android:textSize="16sp"
- android:textColor="@color/snippets_headline_text_color" />
+ android:textColor="@color/snippets_headline_text_color"
+ chrome:leading="24dp" />
- <TextView
+ <org.chromium.ui.widget.TextViewWithLeading
android:id="@+id/article_snippet"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_alignParentStart="true"
android:layout_below="@+id/article_headline"
android:layout_toStartOf="@+id/article_thumbnail"
- android:maxLines="2"
android:layout_marginTop="8dp"
+ android:maxLines="2"
android:ellipsize="end"
android:textSize="14sp"
- android:textColor="@color/snippets_text_color" />
+ android:textColor="@color/snippets_text_color"
+ chrome:leading="20dp" />
<TextView
android:id="@+id/article_publisher"
« no previous file with comments | « no previous file | ui/android/BUILD.gn » ('j') | ui/android/java/src/org/chromium/ui/widget/TextViewWithLeading.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698