Added Validation to Vulkan CommandBuffer API's.

gpu/vulkan/vulkan_command_buffer.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/vulkan/vulkan_command_buffer.h"
 
 #include "base/logging.h"
 #include "gpu/vulkan/vulkan_command_pool.h"
 #include "gpu/vulkan/vulkan_device_queue.h"
 #include "gpu/vulkan/vulkan_implementation.h"
@@ skipping 126 matching lines @@
     record_type_ = RECORD_TYPE_DIRTY;
   } else if (record_type_ == RECORD_TYPE_MULTI_USE) {
     // Can no longer record new items unless marked as clear.
     record_type_ = RECORD_TYPE_RECORDED;
   }
 }
 
 void VulkanCommandBuffer::ResetIfDirty() {
   DCHECK(!recording_);
   if (record_type_ == RECORD_TYPE_DIRTY) {
+    VkResult result = VK_SUCCESS;

[piman, 2016/05/12 23:20:43]

nit: move declaration to initialization (l. 153)

[ssami, 2016/05/13 08:45:46]

Done.

     // Block if command buffer is still in use. This can be externally avoided
     // using the asynchronous SubmissionFinished() function.
     VkDevice device = device_queue_->GetVulkanDevice();
     vkWaitForFences(device, 1, &submission_fence_, true, UINT64_MAX);
 
-    vkResetCommandBuffer(command_buffer_, 0);
-    record_type_ = RECORD_TYPE_EMPTY;
+    result = vkResetCommandBuffer(command_buffer_, 0);

[piman, 2016/05/12 23:20:43]

nit: VkResult result = vkResetCommandBuffer(command_buffer_, 0);

[ssami, 2016/05/13 08:45:46]

Done.

+    if (VK_SUCCESS != result) {
+      DLOG(ERROR) << "vkResetCommandBuffer() failed: " << result;
+    } else {
+      record_type_ = RECORD_TYPE_EMPTY;
+    }
   }
 }
 
 CommandBufferRecorderBase::~CommandBufferRecorderBase() {
-  vkEndCommandBuffer(handle_);
+  VkResult result = VK_SUCCESS;
+  result = vkEndCommandBuffer(handle_);

[piman, 2016/05/12 23:20:43]

nit: VkResult result = vkEndCommandBuffer(handle_);

[ssami, 2016/05/13 08:45:46]

Done.

+
+  if (VK_SUCCESS != result) {
+    DLOG(ERROR) << "vkEndCommandBuffer() failed: " << result;
+  }
 };
 
 ScopedMultiUseCommandBufferRecorder::ScopedMultiUseCommandBufferRecorder(
     VulkanCommandBuffer& command_buffer)
     : CommandBufferRecorderBase(command_buffer) {
+  VkResult result = VK_SUCCESS;
   ValidateMultiUse(command_buffer);
   VkCommandBufferBeginInfo begin_info = {};
   begin_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
-  vkBeginCommandBuffer(handle_, &begin_info);
+  result = vkBeginCommandBuffer(handle_, &begin_info);

[piman, 2016/05/12 23:20:43]

nit: VkResult result = vkBeginCommandBuffer(handle_, &begin_info);

[ssami, 2016/05/13 08:45:46]

Done.

+
+  if (VK_SUCCESS != result) {
+    DLOG(ERROR) << "vkBeginCommandBuffer() failed: " << result;
+  }
 }
 
 ScopedSingleUseCommandBufferRecorder::ScopedSingleUseCommandBufferRecorder(
     VulkanCommandBuffer& command_buffer)
     : CommandBufferRecorderBase(command_buffer) {
+  VkResult result = VK_SUCCESS;
   ValidateSingleUse(command_buffer);
   VkCommandBufferBeginInfo begin_info = {};
   begin_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
   begin_info.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
-  vkBeginCommandBuffer(handle_, &begin_info);
+  result = vkBeginCommandBuffer(handle_, &begin_info);

[piman, 2016/05/12 23:20:43]

nit: VkResult result = vkBeginCommandBuffer(handle_, &begin_info);

[ssami, 2016/05/13 08:45:46]

Done.

+
+  if (VK_SUCCESS != result) {
+    DLOG(ERROR) << "vkBeginCommandBuffer() failed: " << result;
+  }
 }
 
 }  // namespace gpu