Source/core/rendering/RenderGrid.cpp - Issue 19558006: Heap-use-after-free in WebCore::RenderFlexibleBox::firstLineBoxBaseline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 19558006: Heap-use-after-free in WebCore::RenderFlexibleBox::firstLineBoxBaseline (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Removed bad FINAL Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderGrid.cpp

diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp

index b1e831240b2e1e55e831c7cbac4648d30f29677d..237fc541c3322eb1fb824c99d9b6e2b402baca31 100644

--- a/Source/core/rendering/RenderGrid.cpp

+++ b/Source/core/rendering/RenderGrid.cpp

@@ -251,6 +251,12 @@ void RenderGrid::computePreferredLogicalWidths()

setPreferredLogicalWidthsDirty(false);

}

+void RenderGrid::removeChild(RenderObject* child)

ojan 2013/07/19 20:27:50 Needs linebreak

Julien - ping for review 2013/07/19 20:52:31 Done.

+ m_orderIterator.invalidate();

+ RenderBlock::removeChild(child);

LayoutUnit RenderGrid::computePreferredTrackWidth(const GridLength& gridLength, size_t trackIndex) const

{