LayoutTests/fast/flexbox/order-iterator-crash-expected.txt - Issue 19558006: Heap-use-after-free in WebCore::RenderFlexibleBox::firstLineBoxBaseline

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/flexbox/order-iterator-crash-expected.txt

Issue 19558006: Heap-use-after-free in WebCore::RenderFlexibleBox::firstLineBoxBaseline (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Removed bad FINAL Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/flexbox/order-iterator-crash.html ('K') | « LayoutTests/fast/flexbox/order-iterator-crash.html ('k') | Source/core/rendering/OrderIterator.h » ('j') | Source/core/rendering/OrderIterator.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This test has passed if it doesn't crash under ASAN.

	2 * { display: flex; }
	inferno 2013/07/19 20:25:08 Why are these last two lines showing up in expecta Why are these last two lines showing up in expectations file. Julien - ping for review 2013/07/19 20:52:31 That's because we turn <script> and <style> into f Show quoted text On 2013/07/19 20:25:08, inferno wrote: > Why are these last two lines showing up in expectations file. That's because we turn <script> and <style> into flexboxes so they show their content. inferno 2013/07/19 20:57:22 This is weird, but if the crashing testcase cannot Show quoted text On 2013/07/19 20:52:31, Julien Chaffraix wrote: > On 2013/07/19 20:25:08, inferno wrote: > > Why are these last two lines showing up in expectations file. > > That's because we turn <script> and <style> into flexboxes so they show their > content. This is weird, but if the crashing testcase cannot be minimized more (like display:flex on specific elements than ), then it is ok. Julien - ping for review* 2013/07/19 21:05:45 I tried narrowing the * but that didn't work unfor Show quoted text On 2013/07/19 20:57:22, inferno wrote: > On 2013/07/19 20:52:31, Julien Chaffraix wrote: > > On 2013/07/19 20:25:08, inferno wrote: > > > Why are these last two lines showing up in expectations file. > > > > That's because we turn <script> and <style> into flexboxes so they show their > > content. > > This is weird, but if the crashing testcase cannot be minimized more (like > display:flex on specific elements than ), then it is ok. I tried narrowing the but that didn't work unfortunately (like adding the DOCTYPE) so I didn't press further.
	3 if (window.testRunner) testRunner.dumpAsText(); crashy.offsetLeft; crashy.parent Node.removeChild(crashy);

OLD	NEW