Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: Source/core/rendering/RenderFlexibleBox.h

Issue 19558006: Heap-use-after-free in WebCore::RenderFlexibleBox::firstLineBoxBaseline (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated change after the review's comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/OrderIterator.cpp ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 virtual void paintChildren(PaintInfo&, const LayoutPoint&) OVERRIDE FINAL; 57 virtual void paintChildren(PaintInfo&, const LayoutPoint&) OVERRIDE FINAL;
58 58
59 bool isHorizontalFlow() const; 59 bool isHorizontalFlow() const;
60 60
61 protected: 61 protected:
62 virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Layo utUnit& maxLogicalWidth) const OVERRIDE; 62 virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Layo utUnit& maxLogicalWidth) const OVERRIDE;
63 virtual void computePreferredLogicalWidths() OVERRIDE; 63 virtual void computePreferredLogicalWidths() OVERRIDE;
64 64
65 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle); 65 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
66 66
67 virtual void removeChild(RenderObject* child) OVERRIDE;
68
67 private: 69 private:
68 enum FlexSign { 70 enum FlexSign {
69 PositiveFlexibility, 71 PositiveFlexibility,
70 NegativeFlexibility, 72 NegativeFlexibility,
71 }; 73 };
72 74
73 enum PositionedLayoutMode { 75 enum PositionedLayoutMode {
74 FlipForRowReverse, 76 FlipForRowReverse,
75 NoFlipForRowReverse, 77 NoFlipForRowReverse,
76 }; 78 };
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isFlexibleBox()); 173 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isFlexibleBox());
172 return static_cast<const RenderFlexibleBox*>(object); 174 return static_cast<const RenderFlexibleBox*>(object);
173 } 175 }
174 176
175 // This will catch anyone doing an unnecessary cast. 177 // This will catch anyone doing an unnecessary cast.
176 void toRenderFlexibleBox(const RenderFlexibleBox*); 178 void toRenderFlexibleBox(const RenderFlexibleBox*);
177 179
178 } // namespace WebCore 180 } // namespace WebCore
179 181
180 #endif // RenderFlexibleBox_h 182 #endif // RenderFlexibleBox_h
OLDNEW
« no previous file with comments | « Source/core/rendering/OrderIterator.cpp ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698