third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html - Issue 1955723004: Implement font-variant-numeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html

Issue 1955723004: Implement font-variant-numeric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: eae@'s review comments addressed Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/font-shorthand-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html b/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html

index eada5ce3535301928e2d0d1d17aab22a8662fe18..78308081acfa3f974b3fd9a798ba5a7bf4615427 100644

--- a/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html

+++ b/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html

@@ -81,6 +81,15 @@ style.fontVariantLigatures = "normal";

shouldBe("style.font", "'italic small-caps bold ultra-expanded 20px/40px sans-serif'");

shouldBe("computedStyle.font", "'italic small-caps bold ultra-expanded 20px / 40px sans-serif'");

+style.fontVariantNumeric = "lining-nums";

+// Shorthand cannot be built because of non-normal numeric value.

+shouldBe("style.font", "''");

+shouldBe("computedStyle.font", "''");

+// Reset for next test.

+style.fontVariantNumeric = "normal";

+shouldBe("style.font", "'italic small-caps bold ultra-expanded 20px/40px sans-serif'");

+shouldBe("computedStyle.font", "'italic small-caps bold ultra-expanded 20px / 40px sans-serif'");

style.font = "";

shouldBe("style.font", "''");

shouldBe("computedStyle.font", "'normal normal normal normal 16px / normal foobar'");