Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1955723003: Add GN targets for samples (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add GN targets for samples BUG=chromium:609107 R=machenbach@chromium.org LOG=n Committed: https://crrev.com/19a8e09cc0bafa5071c52243234bfc8512210065 Cr-Commit-Position: refs/heads/master@{#36072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-06 09:31:30 UTC) #1
Michael Achenbach
Principally lgtm. Some questions that we can address in follow ups: Can BUILD.gn be split ...
4 years, 7 months ago (2016-05-06 10:29:58 UTC) #2
jochen (gone - plz use gerrit)
On 2016/05/06 at 10:29:58, machenbach wrote: > Principally lgtm. Some questions that we can address ...
4 years, 7 months ago (2016-05-06 10:36:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955723003/1
4 years, 7 months ago (2016-05-06 10:37:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 10:39:33 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19a8e09cc0bafa5071c52243234bfc8512210065 Cr-Commit-Position: refs/heads/master@{#36072}
4 years, 7 months ago (2016-05-06 10:40:32 UTC) #8
Michael Hablich
4 years, 7 months ago (2016-05-09 06:41:10 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1955353002/ by hablich@chromium.org.

The reason for reverting is: Blocks roll:
https://codereview.chromium.org/1956223002/.

Powered by Google App Engine
This is Rietveld 408576698