Improve detail of some texture-related errors.

Improve detail of some texture-related errors.

Some of these errors are showing up in the web console for the affected
application. Having more detail speeds up debugging on Chrome's side.

BUG=605129
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a3692c199187bf625e3caffb3bad4789359ff840
Cr-Commit-Position: refs/heads/master@{#391972}

[Ken Russell (switch to Gerrit), 2016-05-05 22:52:50]

Description was changed from

==========
Improve detail of some texture-related errors.

Some of these errors are showing up in the web console for the affected
application. Having more detail speeds up debugging on Chrome's side.

BUG=605129
==========

to

==========
Improve detail of some texture-related errors.

Some of these errors are showing up in the web console for the affected
application. Having more detail speeds up debugging on Chrome's side.

BUG=605129
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-05-05 22:55:56]

kbr@chromium.org changed reviewers:
+ piman@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-05-05 22:55:56]

Please review.

I don't want to push too hard for this -- piman, I know you're understandably
concerned about proliferation of logging code -- but these errors show up in the
web console and having the additional detail would have sped up debugging of
this large application.

Thanks.

[Zhenyao Mo, 2016-05-05 22:59:43]

lgtm

[Ken Russell (switch to Gerrit), 2016-05-05 23:10:03]

On 2016/05/05 22:59:43, Zhenyao Mo wrote:
> lgtm

piman, hope this is OK with you. CQ'ing.

[Ken Russell (switch to Gerrit), 2016-05-05 23:10:06]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-05-05 23:10:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955723002/20001

[piman, 2016-05-05 23:28:48]

I would like us to find a long term solution to this. Adding tons and tons of
strings and logging code to the GPU bloats the code (concern on Android) and
slows it down (i-cache concerns), given that an extremely small portion of our
users will ever see these let alone take action on them.
I don't think it's our responsibility to do this in Chrome, at least in official
builds, where a GL state tracking interposer library at the JavaScript level
could do the job instead - without forcing this code on all our users.

[Zhenyao Mo, 2016-05-05 23:47:30]

On 2016/05/05 23:28:48, piman wrote:
> I would like us to find a long term solution to this. Adding tons and tons of
> strings and logging code to the GPU bloats the code (concern on Android) and
> slows it down (i-cache concerns), given that an extremely small portion of our
> users will ever see these let alone take action on them.
> I don't think it's our responsibility to do this in Chrome, at least in
official
> builds, where a GL state tracking interposer library at the JavaScript level
> could do the job instead - without forcing this code on all our users.

We can turn all of them to DLOG if mostly it's for us debugging.

[Ken Russell (switch to Gerrit), 2016-05-06 00:15:29]

On 2016/05/05 23:47:30, Zhenyao Mo wrote:
> On 2016/05/05 23:28:48, piman wrote:
> > I would like us to find a long term solution to this. Adding tons and tons
of
> > strings and logging code to the GPU bloats the code (concern on Android) and
> > slows it down (i-cache concerns), given that an extremely small portion of
our
> > users will ever see these let alone take action on them.
> > I don't think it's our responsibility to do this in Chrome, at least in
> official
> > builds, where a GL state tracking interposer library at the JavaScript level
> > could do the job instead - without forcing this code on all our users.
> 
> We can turn all of them to DLOG if mostly it's for us debugging.

These particular messages are deliberately surfaced in the JS console, so they
need to be release-mode. It's been extremely useful that when these GL errors
are generated, the detail message is printed there. Firefox does the same, and
contains this detail where Chrome currently doesn't.

I'm all for figuring out how to solve this in a better way and would appreciate
any suggestions -- will be happy to help improve the code.

[commit-bot: I haz the power, 2016-05-06 00:58:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-06 01:00:06]

Description was changed from

==========
Improve detail of some texture-related errors.

Some of these errors are showing up in the web console for the affected
application. Having more detail speeds up debugging on Chrome's side.

BUG=605129
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Improve detail of some texture-related errors.

Some of these errors are showing up in the web console for the affected
application. Having more detail speeds up debugging on Chrome's side.

BUG=605129
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a3692c199187bf625e3caffb3bad4789359ff840
Cr-Commit-Position: refs/heads/master@{#391972}
==========

[commit-bot: I haz the power, 2016-05-06 01:00:08]

Patchset 2 (id:??) landed as
https://crrev.com/a3692c199187bf625e3caffb3bad4789359ff840
Cr-Commit-Position: refs/heads/master@{#391972}