Don't apply container flip when computing offset to transformed ancestor.

Don't apply container flip when computing offset to transformed ancestor.

Coordinates of PaintLayers are already in physical space.

BUG=599757
Committed: https://crrev.com/ddc6af1c80430a1dc846829ddb42bd61a2f21ff1
Cr-Commit-Position: refs/heads/master@{#392407}

[chrishtr, 2016-05-06 20:24:57]

Description was changed from

==========
none


none

BUG=
==========

to

==========
Don't apply container flip when computing offset to transformed ancestor.

BUG=
==========

[chrishtr, 2016-05-06 20:25:39]

Description was changed from

==========
Don't apply container flip when computing offset to transformed ancestor.

BUG=
==========

to

==========
Don't apply container flip when computing offset to transformed ancestor.

Coordinates of PaintLayers are already in physical space.

BUG=599757
==========

[chrishtr, 2016-05-06 22:18:27]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-05-06 22:25:04]

lgtm with comments.

https://codereview.chromium.org/1955703004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/compositing/squashing/vertical-writing-mode-squashed.html
(right):

https://codereview.chromium.org/1955703004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/compositing/squashing/vertical-writing-mode-squashed.html:2:
<div style="-webkit-writing-mode: vertical-rl; width: 400px; height: 400px;
overflow-x: auto; backface-visibility: hidden">
Nit: omit '-webkit-' prefix.

https://codereview.chromium.org/1955703004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/1955703004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.h:99: // generally be used
when mapping a source rect in a logical space to one in a physical
"logical space" is not accurate. It's the third coordinate space ('physical
coordinates with flipped block-flow direction') described in the doc of
LayoutBoxModelObject.

[chrishtr, 2016-05-09 16:47:43]

https://codereview.chromium.org/1955703004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/compositing/squashing/vertical-writing-mode-squashed.html
(right):

https://codereview.chromium.org/1955703004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/compositing/squashing/vertical-writing-mode-squashed.html:2:
<div style="-webkit-writing-mode: vertical-rl; width: 400px; height: 400px;
overflow-x: auto; backface-visibility: hidden">
On 2016/05/06 at 22:25:04, Xianzhu wrote:
> Nit: omit '-webkit-' prefix.

Done.

https://codereview.chromium.org/1955703004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/1955703004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.h:99: // generally be used
when mapping a source rect in a logical space to one in a physical
On 2016/05/06 at 22:25:04, Xianzhu wrote:
> "logical space" is not accurate. It's the third coordinate space ('physical
coordinates with flipped block-flow direction') described in the doc of
LayoutBoxModelObject.

Done.

[chrishtr, 2016-05-09 16:56:23]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-05-09 16:56:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/1955703004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-09 16:56:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955703004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955703004/80001

[commit-bot: I haz the power, 2016-05-09 20:12:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-09 20:14:29]

Description was changed from

==========
Don't apply container flip when computing offset to transformed ancestor.

Coordinates of PaintLayers are already in physical space.

BUG=599757
==========

to

==========
Don't apply container flip when computing offset to transformed ancestor.

Coordinates of PaintLayers are already in physical space.

BUG=599757

Committed: https://crrev.com/ddc6af1c80430a1dc846829ddb42bd61a2f21ff1
Cr-Commit-Position: refs/heads/master@{#392407}
==========

[commit-bot: I haz the power, 2016-05-09 20:14:30]

Patchset 5 (id:??) landed as
https://crrev.com/ddc6af1c80430a1dc846829ddb42bd61a2f21ff1
Cr-Commit-Position: refs/heads/master@{#392407}