third_party/WebKit/Source/modules/ModulesInitializer.cpp - Issue 1955693003: compositor-worker: Keep worker backing thread alive for the lifetime of the compositor thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/ModulesInitializer.cpp

Issue 1955693003: compositor-worker: Keep worker backing thread alive for the lifetime of the compositor thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded scheduler changes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp » ('j') | third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/ModulesInitializer.cpp

diff --git a/third_party/WebKit/Source/modules/ModulesInitializer.cpp b/third_party/WebKit/Source/modules/ModulesInitializer.cpp

index 6c6943020eeb1a16233c823279bec376cf663bec..7aa23eccc1a979831b46504314996e9922b75e28 100644

--- a/third_party/WebKit/Source/modules/ModulesInitializer.cpp

+++ b/third_party/WebKit/Source/modules/ModulesInitializer.cpp

@@ -16,6 +16,7 @@

#include "modules/IndexedDBNames.h"

#include "modules/accessibility/AXObjectCacheImpl.h"

#include "modules/canvas2d/CanvasRenderingContext2D.h"

+#include "modules/compositorworker/CompositorWorkerThread.h"

#include "modules/csspaint/CSSPaintImageGeneratorImpl.h"

#include "modules/filesystem/DraggedIsolatedFileSystemImpl.h"

#include "modules/imagebitmap/ImageBitmapRenderingContext.h"

@@ -63,6 +64,7 @@ void ModulesInitializer::initialize()

void ModulesInitializer::shutdown()

{

ASSERT(isInitialized());

+ CompositorWorkerThread::clearSharedBackingThread();

yhirano 2016/05/19 05:35:37 I think this should be placed after CoreInitialize

flackr 2016/05/19 22:24:16 Yes, correct. This should happen after the worker

DatabaseManager::terminateDatabaseThread();

CoreInitializer::shutdown();

}