third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp - Issue 1955693003: compositor-worker: Keep worker backing thread alive for the lifetime of the compositor thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

Issue 1955693003: compositor-worker: Keep worker backing thread alive for the lifetime of the compositor thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expand on comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp ('K') | « third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

index c2fcf32d3597d9d9db7c90ae4bb922bdab7a45db..3787b2f50432f4b16323cc855d6854d7ddd21260 100644

--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

@@ -91,7 +91,7 @@ public:

void TearDown() override

{

m_page.clear();

- CompositorWorkerThread::resetSharedBackingThreadForTest();

+ CompositorWorkerThread::clearSharedBackingThread();

yhirano 2016/05/11 02:21:02 I think the latter half of https://codereview.chro

flackr 2016/05/18 05:26:50 It is a bit fragile, though we normally don't re-u

}

PassOwnPtr<CompositorWorkerThread> createCompositorWorker()