third_party/WebKit/Source/modules/ModulesInitializer.cpp - Issue 1955693003: compositor-worker: Keep worker backing thread alive for the lifetime of the compositor thread.

Unified Diff: third_party/WebKit/Source/modules/ModulesInitializer.cpp

Issue 1955693003: compositor-worker: Keep worker backing thread alive for the lifetime of the compositor thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp ('k') | third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp » ('j') | third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/ModulesInitializer.cpp

diff --git a/third_party/WebKit/Source/modules/ModulesInitializer.cpp b/third_party/WebKit/Source/modules/ModulesInitializer.cpp

index 6c6943020eeb1a16233c823279bec376cf663bec..7aa23eccc1a979831b46504314996e9922b75e28 100644

--- a/third_party/WebKit/Source/modules/ModulesInitializer.cpp

+++ b/third_party/WebKit/Source/modules/ModulesInitializer.cpp

@@ -16,6 +16,7 @@

#include "modules/IndexedDBNames.h"

#include "modules/accessibility/AXObjectCacheImpl.h"

#include "modules/canvas2d/CanvasRenderingContext2D.h"

+#include "modules/compositorworker/CompositorWorkerThread.h"

#include "modules/csspaint/CSSPaintImageGeneratorImpl.h"

#include "modules/filesystem/DraggedIsolatedFileSystemImpl.h"

#include "modules/imagebitmap/ImageBitmapRenderingContext.h"

@@ -63,6 +64,7 @@ void ModulesInitializer::initialize()

void ModulesInitializer::shutdown()

{

ASSERT(isInitialized());

+ CompositorWorkerThread::clearSharedBackingThread();

haraken 2016/05/09 02:00:53 Backing threads of other workers are shut down in

flackr 2016/05/10 18:07:39 This does make sense, however core/ is not allowed

haraken 2016/05/11 00:18:31 Can we add some virtual method on WorkerThread and

flackr 2016/05/18 05:26:49 No, the problem is that the backing thread is a si

DatabaseManager::terminateDatabaseThread();

CoreInitializer::shutdown();

}