third_party/WebKit/Source/platform/PlatformTouchEvent.h - Issue 1955643002: Add UMA metric to track the time saved on making events passive during fling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/PlatformTouchEvent.h

Issue 1955643002: Add UMA metric to track the time saved on making events passive during fling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set dispatch type to forcepassive Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/PlatformTouchEvent.h

diff --git a/third_party/WebKit/Source/platform/PlatformTouchEvent.h b/third_party/WebKit/Source/platform/PlatformTouchEvent.h

index 88005d12de29deab0e78aeb6a3094b792bf429fd..9a0a310d3927c32a131023865d778a060c35670c 100644

--- a/third_party/WebKit/Source/platform/PlatformTouchEvent.h

+++ b/third_party/WebKit/Source/platform/PlatformTouchEvent.h

@@ -39,7 +39,7 @@ public:

const Vector<PlatformTouchPoint>& touchPoints() const { return m_touchPoints; }

DispatchType dispatchType() const { return m_dispatchType; }

- bool cancelable() const { return m_dispatchType == PlatformEvent::Blocking; }

dtapuska 2016/05/05 19:58:27 ok this seems wrong to me; if listeners are forced

+ bool cancelable() const { return m_dispatchType == PlatformEvent::Blocking || m_dispatchType == ListenersForcedNonBlockingPassive; }

bool causesScrollingIfUncanceled() const { return m_causesScrollingIfUncanceled; }

bool shouldForceBePassive() const { return m_shouldForceBePassive; }

« content/renderer/input/main_thread_event_queue.cc ('K') | « content/renderer/input/main_thread_event_queue.cc ('k') | no next file » | no next file with comments »