src/hydrogen.cc - Issue 19556003: Fix LiteralCompareTypeof breakage introduced in r15723

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 19556003: Fix LiteralCompareTypeof breakage introduced in r15723 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 7d120b7f81749248831427c13e952e86df40e850..f723e8a14183ae4da589e8e7e80edbd31abc2d59 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -8135,7 +8135,8 @@ void HOptimizedGraphBuilder::HandleLiteralCompareTypeof(CompareOperation* expr,

Expression* sub_expr,

Handle<String> check) {

CHECK_ALIVE(VisitForValue(sub_expr));

- HValue* value = Pop();

+ HTypeof* htypeof = HTypeof::cast(Pop());

+ HValue* value = htypeof->value();

HTypeofIsAndBranch* instr = new(zone()) HTypeofIsAndBranch(value, check);

instr->set_position(expr->position());

return ast_context()->ReturnControl(instr, expr->id());

« no previous file with comments | « src/ast.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »