Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1955593003: S390: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm m… (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code. port 117a56b7c2a88ab2b2f25fad88517d72f5edbac9 Original commit message: - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add relocation information to immediates in compare instructions. - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler R=gdeepti@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/79c350b3c59846052fb962eb20ec11956d000271 Cr-Commit-Position: refs/heads/master@{#36056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -23 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/s390/assembler-s390.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/s390/assembler-s390-inl.h View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-05 15:11:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955593003/1
4 years, 7 months ago (2016-05-05 15:12:12 UTC) #3
JoranSiu
On 2016/05/05 15:12:12, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 7 months ago (2016-05-05 15:26:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 15:37:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955593003/1
4 years, 7 months ago (2016-05-05 16:31:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 19:12:19 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 19:12:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79c350b3c59846052fb962eb20ec11956d000271
Cr-Commit-Position: refs/heads/master@{#36056}

Powered by Google App Engine
This is Rietveld 408576698