Issue 19555004: Add test to ensure buildTileIndex stores SkStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19555004: Add test to ensure buildTileIndex stores SkStream. (Closed)

Created:
7 years, 5 months ago by scroggo

Modified:
7 years, 5 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add test to ensure buildTileIndex stores SkStream. PNG fails this test without https://codereview.chromium.org/19185006/ R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10163

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -0 lines)			Patch
	M	tests/ImageDecodingTest.cpp	View		2 chunks	+77 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm https://codereview.chromium.org/19555004/diff/1/tests/ImageDecodingTest.cpp File tests/ImageDecodingTest.cpp (right): https://codereview.chromium.org/19555004/diff/1/tests/ImageDecodingTest.cpp#newcode229 tests/ImageDecodingTest.cpp:229: SkImageEncoder::kJPEG_Type, not needed for this CL, but we ...

7 years, 5 months ago (2013-07-17 19:52:17 UTC) #2

scroggo

7 years, 5 months ago (2013-07-18 20:06:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r10163 (presubmit successful).

Expand Messages | Collapse Messages