Move BlimpImageSerializationProcessor and WebPDecoder to //blimp/client

Move BlimpImageSerializationProcessor and WebPDecoder to //blimp/client

The ImageSerializationProcessor implementation in //blimp started off as a
single implementation with an enum passed in to it according to whether it
was used for serialization or deserialization.

The CL https://codereview.chromium.org/1859753002 changed this to have
two implementations, such that one of them would only be used for the engine
and one for the client. However, the one used in the client code after this
still lived in //blimp/common and maintained some of the complexity such
as the enum for the mode it should be in.

This CL changes this by moving the remaining class
BlimpImageSerializationProcessor to //blimp/client and also renaming it
accordingly to ClientImageSerializationProcessor. It also removes the extra
complexity with the two different types.

In addition, since it was the only part outside of client that was using
the WebPDecoder, the WebPDecoder itself is now also moved to //blimp/client.

Lastly, this CL removes some incorrect dependencies from the engine code,
and cleans up the GN build targets related to this change.

BUG=597811
Committed: https://crrev.com/60578afb06436fb73badef7b66d5d699f9623441
Cr-Commit-Position: refs/heads/master@{#391940}

[nyquist, 2016-05-04 23:37:58]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 23:38:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955493002/1

[nyquist, 2016-05-04 23:38:35]

nyquist@chromium.org changed reviewers:
+ kmarshall@chromium.org

[nyquist, 2016-05-04 23:38:36]

kmarshall: PTAL

khushalsagar: FYI

[commit-bot: I haz the power, 2016-05-05 02:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 02:16:54]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nyquist, 2016-05-05 14:51:33]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 14:51:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955493002/1

[commit-bot: I haz the power, 2016-05-05 14:54:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 14:54:41]

Dry run: This issue passed the CQ dry run.

[Khushal, 2016-05-05 18:27:11]

Thank you! :P

[Kevin M, 2016-05-05 19:34:40]

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
File blimp/client/feature/compositor/blimp_compositor.h (right):

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
blimp/client/feature/compositor/blimp_compositor.h:37: class
ClientImageSerializationProcessor;
I don't see this class referenced in this file. Remove this forward declaration?

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
File blimp/client/feature/compositor/blimp_compositor_manager.h (right):

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
blimp/client/feature/compositor/blimp_compositor_manager.h:16: 
Add forward declaration for ClientImageSerializationProcessor here

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
File blimp/client/feature/compositor/blimp_compositor_unittest.cc (right):

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
blimp/client/feature/compositor/blimp_compositor_unittest.cc:23: :
compositor_thread_("Compositor"), image_serialization_processor_() {
No need to initialize image_serialization_processor_ here if you're just initing
it to a default value.

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
File blimp/client/feature/compositor/webp_decoder.h (right):

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
blimp/client/feature/compositor/webp_decoder.h:16: bool WebPDecoder(const void*
input, size_t input_size, SkBitmap* bitmap);
We should give this a better name, because this does more than simply decoding
WebP images?

[nyquist, 2016-05-05 21:26:08]

kmarshall: PTAL

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
File blimp/client/feature/compositor/blimp_compositor.h (right):

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
blimp/client/feature/compositor/blimp_compositor.h:37: class
ClientImageSerializationProcessor;
On 2016/05/05 19:34:39, Kevin M wrote:
> I don't see this class referenced in this file. Remove this forward
declaration?

Done.

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
File blimp/client/feature/compositor/blimp_compositor_manager.h (right):

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
blimp/client/feature/compositor/blimp_compositor_manager.h:16: 
On 2016/05/05 19:34:40, Kevin M wrote:
> Add forward declaration for ClientImageSerializationProcessor here

Done.

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
File blimp/client/feature/compositor/blimp_compositor_unittest.cc (right):

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
blimp/client/feature/compositor/blimp_compositor_unittest.cc:23: :
compositor_thread_("Compositor"), image_serialization_processor_() {
On 2016/05/05 19:34:40, Kevin M wrote:
> No need to initialize image_serialization_processor_ here if you're just
initing
> it to a default value.

Done.

[nyquist, 2016-05-05 21:26:14]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[Kevin M, 2016-05-05 21:26:38]

lgtm

...because my comments were basically all nits.

[commit-bot: I haz the power, 2016-05-05 21:27:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955493002/20001

[nyquist, 2016-05-05 21:44:41]

Oh... also done with the webp one.... sorry about that.

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
File blimp/client/feature/compositor/webp_decoder.h (right):

https://codereview.chromium.org/1955493002/diff/1/blimp/client/feature/compos...
blimp/client/feature/compositor/webp_decoder.h:16: bool WebPDecoder(const void*
input, size_t input_size, SkBitmap* bitmap);
On 2016/05/05 19:34:40, Kevin M wrote:
> We should give this a better name, because this does more than simply decoding
> WebP images?

Done.

[nyquist, 2016-05-05 21:44:55]

The CQ bit was unchecked by nyquist@chromium.org

[nyquist, 2016-05-05 21:45:01]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2016-05-05 21:45:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955493002/20001

[commit-bot: I haz the power, 2016-05-05 23:12:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-05 23:14:03]

Description was changed from

==========
Move BlimpImageSerializationProcessor and WebPDecoder to //blimp/client

The ImageSerializationProcessor implementation in //blimp started off as a
single implementation with an enum passed in to it according to whether it
was used for serialization or deserialization.

The CL https://codereview.chromium.org/1859753002 changed this to have
two implementations, such that one of them would only be used for the engine
and one for the client. However, the one used in the client code after this
still lived in //blimp/common and maintained some of the complexity such
as the enum for the mode it should be in.

This CL changes this by moving the remaining class
BlimpImageSerializationProcessor to //blimp/client and also renaming it
accordingly to ClientImageSerializationProcessor. It also removes the extra
complexity with the two different types.

In addition, since it was the only part outside of client that was using
the WebPDecoder, the WebPDecoder itself is now also moved to //blimp/client.

Lastly, this CL removes some incorrect dependencies from the engine code,
and cleans up the GN build targets related to this change.

BUG=597811
==========

to

==========
Move BlimpImageSerializationProcessor and WebPDecoder to //blimp/client

The ImageSerializationProcessor implementation in //blimp started off as a
single implementation with an enum passed in to it according to whether it
was used for serialization or deserialization.

The CL https://codereview.chromium.org/1859753002 changed this to have
two implementations, such that one of them would only be used for the engine
and one for the client. However, the one used in the client code after this
still lived in //blimp/common and maintained some of the complexity such
as the enum for the mode it should be in.

This CL changes this by moving the remaining class
BlimpImageSerializationProcessor to //blimp/client and also renaming it
accordingly to ClientImageSerializationProcessor. It also removes the extra
complexity with the two different types.

In addition, since it was the only part outside of client that was using
the WebPDecoder, the WebPDecoder itself is now also moved to //blimp/client.

Lastly, this CL removes some incorrect dependencies from the engine code,
and cleans up the GN build targets related to this change.

BUG=597811

Committed: https://crrev.com/60578afb06436fb73badef7b66d5d699f9623441
Cr-Commit-Position: refs/heads/master@{#391940}
==========

[commit-bot: I haz the power, 2016-05-05 23:14:04]

Patchset 2 (id:??) landed as
https://crrev.com/60578afb06436fb73badef7b66d5d699f9623441
Cr-Commit-Position: refs/heads/master@{#391940}