Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1955473002: Enable code object tests for DBC (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + runtime/vm/object_dbc_test.cc View 4 chunks +15 lines, -16 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 7 months ago (2016-05-04 22:53:19 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 7 months ago (2016-05-05 16:01:21 UTC) #3
zra
4 years, 7 months ago (2016-05-05 20:49:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
924214d69587ec4d433989aa85da3d8730df41fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698