Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1955453002: - Use a map to lookup libraries by URL. (Closed)

Created:
4 years, 7 months ago by Ivan Posva
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Use a map to lookup libraries by URL. - Ensure the uniqueness of private keys without having to search the existing key space. - Pass a thread parameter where useful to library methods. BUG=

Patch Set 1 #

Patch Set 2 : Fix precompiler handling. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -419 lines) Patch
M runtime/lib/vmservice.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/cha_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_descriptors_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_generator_test.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_api_impl.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M runtime/vm/isolate.cc View 3 chunks +21 lines, -15 lines 0 comments Download
M runtime/vm/method_recognizer.h View 11 chunks +275 lines, -274 lines 2 comments Download
M runtime/vm/object.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 12 chunks +125 lines, -66 lines 2 comments Download
M runtime/vm/object_store.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/resolver_test.cc View 4 chunks +16 lines, -12 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame_test.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
4 years, 7 months ago (2016-05-05 00:37:57 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/1955453002/diff/20001/runtime/vm/method_recognizer.h File runtime/vm/method_recognizer.h (right): https://codereview.chromium.org/1955453002/diff/20001/runtime/vm/method_recognizer.h#newcode508 runtime/vm/method_recognizer.h:508: /*ASSERT*/(f.CheckSourceFingerprint(#p0 ", " #p1 ", " #p2, ...
4 years, 7 months ago (2016-05-05 16:53:31 UTC) #3
Ivan Posva
Continuing review in this new CL: https://codereview.chromium.org/1947393003 -Ivan https://codereview.chromium.org/1955453002/diff/20001/runtime/vm/method_recognizer.h File runtime/vm/method_recognizer.h (right): https://codereview.chromium.org/1955453002/diff/20001/runtime/vm/method_recognizer.h#newcode508 runtime/vm/method_recognizer.h:508: /*ASSERT*/(f.CheckSourceFingerprint(#p0 ...
4 years, 7 months ago (2016-05-05 17:31:44 UTC) #4
rmacnak
4 years, 7 months ago (2016-05-05 18:14:15 UTC) #5
Message was sent while issue was closed. 
Committed via another CL as b2ac279269f46916681e5b0f44f2e5eb04034e3a.

Powered by Google App Engine
This is Rietveld 408576698