Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2570)

Unified Diff: dashboard/dashboard/elements/report-page.html

Issue 1955433004: [Polymer10] Convert triage-dialog, test-picker, and report-page to Polymer 1.0 (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/elements/test-picker.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/elements/report-page.html
diff --git a/dashboard/dashboard/elements/report-page.html b/dashboard/dashboard/elements/report-page.html
index 03b03b72b04d25f65327d4e2014804d9b29a0d59..e9d9c855d4e502c6465e6136c7e14c451241bc47 100644
--- a/dashboard/dashboard/elements/report-page.html
+++ b/dashboard/dashboard/elements/report-page.html
@@ -10,7 +10,7 @@ found in the LICENSE file.
<link rel="import" href="/dashboard/static/simple_xhr.html">
<link rel="import" href="/dashboard/static/uri.html">
-<polymer-element name="report-page" attributes="hasChart charts">
+<dom-module id="report-page">
<template>
<style>
#nav-container {
@@ -20,7 +20,7 @@ found in the LICENSE file.
</style>
<login-warning id="login-warning" loginLink="{{loginUrl}}"
- hidden?="{{isInternalUser}}">
+ hidden$="{{isInternalUser}}">
</login-warning>
<div id="nav-container">
@@ -32,7 +32,7 @@ found in the LICENSE file.
<div id="toasts" hidden>
<div id="warningtoast">
{{warningMessage}}
- <template if="{{warningBug}}">
+ <template is="dom-if" if="{{!!warningBug}}">
<a href="https://github.com/catapult-project/catapult/issues/{{warningBug}}">See
bug #{{warningBug}}.</a>
</template>
@@ -45,6 +45,13 @@ found in the LICENSE file.
'use strict';
Polymer('report-page', {
+ is: 'report-page',
+ properties: {
+ charts: { notify: true },
+ hasChart: { notify: true },
+ onRevisionRange: { observer: 'onRevisionRangeChanged' }
+ },
+
ready: function() {
simple_xhr.send('/report', uri.getAllParameters(),
function(response) {
@@ -132,10 +139,10 @@ found in the LICENSE file.
var chart = document.createElement('chart-container');
if (isPrepend) {
this.charts.unshift(chart);
- container.insertBefore(chart, container.firstChild);
+ Polymer.dom(container).insertBefore(chart, container.firstChild);
} else {
this.charts.push(chart);
- container.appendChild(chart);
+ Polymer.dom(container).appendChild(chart);
}
chart.addEventListener(
@@ -189,7 +196,7 @@ found in the LICENSE file.
* When the revision range changes for one graph, update the rest of
* the graphs and the URI.
*/
- onRevisionRangeChanged: function(event) {
+ onRevisionRangeChanged: function(_, event) {
for (var i = 0; i < this.charts.length; i++) {
var chart = this.charts[i];
if (chart == event.target) {
@@ -247,4 +254,4 @@ found in the LICENSE file.
}
});
</script>
-</polymer-element>
+</dom-module>
« no previous file with comments | « no previous file | dashboard/dashboard/elements/test-picker.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698