[webcrypto] Implement structured clone of keys (blink-side).

LayoutTests/crypto/resources/common.js

Index: LayoutTests/crypto/resources/common.js
diff --git a/LayoutTests/crypto/resources/common.js b/LayoutTests/crypto/resources/common.js
index 591044aa641455d00a7d76c0d787ebf9bc79bcc1..2189674bad50a0a7d9abe71debdf1273d8eb9ffa 100644
--- a/LayoutTests/crypto/resources/common.js
+++ b/LayoutTests/crypto/resources/common.js
@@ -106,13 +106,19 @@ function addTask(promise)
 {
     numOutstandingTasks++;
 
-    function taskFinished()
+    function taskSucceeded()
     {
         numOutstandingTasks--;
         completeTestWhenAllTasksDone();
     }
 
-    promise.then(taskFinished, taskFinished);
+    function taskFailed(error)
+    {
+        debug('Task failed: ' + error);

[jsbell, 2014/03/13 20:16:07]

testFailed() ?

Looks like testPassed() / testFailed() could be retrofitted into many of these
helper functions. (That could be a follow-up patch since it may require new
baselines for other tests.)

[eroman, 2014/03/14 05:24:33]

I have removed this change, and am building a single promise chain directly in
the tests. Will clean up the pre-existing tests in a separate changelist.

+        taskSucceeded();
+    }
+
+    promise.then(taskSucceeded, taskFailed);
 }
 
 function completeTestWhenAllTasksDone()
@@ -158,3 +164,21 @@ function shouldAcceptPromise(code)
 
     addTask(promise.then(acceptCallback, rejectCallback));
 }
+
+function cloneKeyAndLog(key)
+{
+    var serialized = internals.serializeObject(key);

[jsbell, 2014/03/13 20:16:07]

Obviously, this won't work in a browser. At the expense of making this test even
more async you could construct a MessageChannel and pass the key through the
ports, and cloneKeyAndLog could return a Promise. This wouldn't capture the
serialization, though - and displaying the serialization in the output is a GOOD
THING to make sure we don't accidentally change it, so you'd probably ALSO want
to use the internals, but that could be made conditional. 

Not a big deal, just thought I'd throw out the possibility.

[eroman, 2014/03/14 05:24:33]

Great idea, done!

+    debug("Serialized key bytes: " + bytesToHexString(serialized));
+    return internals.deserializeBuffer(serialized);
+}
+
+// Convert 'x' into a string which can be passed to "shouldBe()"
+function evalWrap(x)
+{
+    var asString = '' + x;
+
+    if (typeof x == 'string')
+        asString = '"' + asString + '"';
+
+    return asString;
+}