third_party/WebKit/Source/core/paint/BoxClipper.cpp - Issue 1955423004: Include selection rect in paint invalidation for LayoutText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxClipper.cpp

Issue 1955423004: Include selection rect in paint invalidation for LayoutText. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync to head and add one test. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/BoxClipper.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxClipper.cpp b/third_party/WebKit/Source/core/paint/BoxClipper.cpp

index c653edffa7e116fc4a761ba4a4f11344c89965a1..e751e965148726fba020c69de43bf0c79c774a0a 100644

--- a/third_party/WebKit/Source/core/paint/BoxClipper.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxClipper.cpp

@@ -47,8 +47,7 @@ BoxClipper::BoxClipper(const LayoutBox& box, const PaintInfo& paintInfo, const L

if (hasBorderRadius)

clipRoundedRect = m_box.style()->getRoundedInnerBorderFor(LayoutRect(accumulatedOffset, m_box.size()));

- // Selection does not affect visual overflow, so this optimization is invalid if selection

- // is present.

+ // Selection may extend beyond visual overflow, so this optimization is invalid if selection is present.

if (contentsClipBehavior == SkipContentsClipIfPossible && box.getSelectionState() == SelectionNone) {

LayoutRect contentsVisualOverflow = m_box.contentsVisualOverflowRect();

if (contentsVisualOverflow.isEmpty())

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.cpp ('k') | no next file » | no next file with comments »