Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 19554002: Remove V8_DISABLE_DEPRECATIONS=1 from test-cpu-profiler.cc (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
Reviewers:
Yang, loislo
CC:
v8-dev
Visibility:
Public.

Description

Remove V8_DISABLE_DEPRECATIONS=1 from test-cpu-profiler.cc BUG=None R=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15716

Patch Set 1 #

Patch Set 2 : Removed redundant fromInfo methods #

Patch Set 3 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M test/cctest/test-cpu-profiler.cc View 1 2 3 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 5 months ago (2013-07-17 09:16:47 UTC) #1
loislo
lgtm
7 years, 5 months ago (2013-07-17 09:49:31 UTC) #2
Yang
On 2013/07/17 09:49:31, loislo wrote: > lgtm lgtm
7 years, 5 months ago (2013-07-17 12:09:55 UTC) #3
yurys
7 years, 5 months ago (2013-07-17 12:16:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698