Update Zlib to version 1.2.8

Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements

BUG=610615
R=agl@chromium.org
R=gavinp@chromium.org

Committed: https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883
Cr-Commit-Position: refs/heads/master@{#400647}

[jiadong.zhu, 2016-05-10 08:10:07]

Patchset #1 (id:1) has been deleted

[jiadong.zhu, 2016-05-10 08:11:39]

Description was changed from

==========
Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

BUG=100000
==========

to

==========
Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

BUG=610615

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged
to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an
empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these
enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw
mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on
any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements
==========

[jiadong.zhu, 2016-05-12 02:45:27]

Description was changed from

==========
Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

BUG=610615

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged
to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an
empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these
enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw
mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on
any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements
==========

to

==========
Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged
to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an
empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these
enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw
mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on
any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements


BUG=610615
R=agl@chromium.org
R=gavinp@chromium.org
==========

[jiadong.zhu, 2016-05-12 02:45:28]

jiadong.zhu@linaro.org changed reviewers:
+ agl@chromium.org, gavinp@chromium.org, khasim.mohammed@linaro.org

[gavinp, 2016-05-12 15:17:19]

The CQ bit was checked by gavinp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 15:17:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955383002/20001

[commit-bot: I haz the power, 2016-05-12 15:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 15:17:33]

Dry run: The author jiadong.zhu@linaro.org has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[gavinp, 2016-05-12 15:19:30]

Did this build on windows?

I think you need to update google.patch, otherwise we're not properly
documenting our divergence.

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/gzlib.c
File third_party/zlib/gzlib.c (left):

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/gzlib....
third_party/zlib/gzlib.c:8: #if defined(_WIN32) && !defined(__BORLANDC__)
Wow, this already had diverged from google.patch...

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/zconf.h
File third_party/zlib/zconf.h (left):

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/zconf....
third_party/zlib/zconf.h:362: #if !defined(_WIN32)
This line was in google.patch, I think it's important.

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/zconf.h
File third_party/zlib/zconf.h (right):

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/zconf....
third_party/zlib/zconf.h:414: #ifdef HAVE_UNISTD_H    /* may be set to #if 1 by
./configure */
I bet this doesn't compile on windows. You probably need to preserve the change
in google.patch.

[gavinp, 2016-05-12 15:23:17]

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/gzlib.c
File third_party/zlib/gzlib.c (left):

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/gzlib....
third_party/zlib/gzlib.c:8: #if defined(_WIN32) && !defined(__BORLANDC__)
also: __BORLANDC__, heh heh.

[jiadong.zhu, 2016-05-15 04:10:52]

The CQ bit was checked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-05-15 04:10:52]

The CQ bit was unchecked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-05-15 04:10:59]

The CQ bit was unchecked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-05-15 04:15:02]

The CQ bit was checked by jiadong.zhu@linaro.org to run a CQ dry run

[jiadong.zhu, 2016-05-15 04:15:13]

The CQ bit was unchecked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-05-15 04:15:14]

The CQ bit was checked by jiadong.zhu@linaro.org

[commit-bot: I haz the power, 2016-05-15 04:15:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955383002/40001

[commit-bot: I haz the power, 2016-05-15 04:15:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-15 04:15:17]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jiadong.zhu, 2016-05-15 04:16:08]

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/gzlib.c
File third_party/zlib/gzlib.c (left):

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/gzlib....
third_party/zlib/gzlib.c:8: #if defined(_WIN32) && !defined(__BORLANDC__)
On 2016/05/12 15:19:29, gavinp wrote:
> Wow, this already had diverged from google.patch...

Thanks for the reply, I upload the google.patch,which is the diff between the
latest chromium zlib and the open source zlib 1.2.8

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/zconf.h
File third_party/zlib/zconf.h (right):

https://codereview.chromium.org/1955383002/diff/20001/third_party/zlib/zconf....
third_party/zlib/zconf.h:414: #ifdef HAVE_UNISTD_H    /* may be set to #if 1 by
./configure */
On 2016/05/12 15:19:30, gavinp wrote:
> I bet this doesn't compile on windows. You probably need to preserve the
change
> in google.patch.

updated in the patchset, please check, thanks

[gavinp, 2016-05-17 14:35:30]

Jiadong,

Thanks for the upload. I think we haven't been very disciplined in how we've
handled upgrades of zlib in the past, and it's a really good idea to clean up
our import of zlib. See https://chromiumcodereview.appspot.com/13564004 to see
some of the pain that's been in the past here. So thank you for paying attention
here.

However, I don't think this CL is quite ready yet. A few observations:

- The update to google.patch you've made seems to combine mixed-sources.patch as
well as jtkukunas' zlib performance work. Probably those should be kept
separate.

- As well, it seems like we're still carrying around changes that can't quite be
explained. See two of my comments in code below. I found these by applying
google.patch and mixed-sources.patch to a clean download of zlib-1.2.8,
generating a diff between that and Chrome, and diffing my diff from your diff.

- jtkukunas' has actually cut a release of his code on 1.2.8! See
https://github.com/jtkukunas/zlib/releases , but I haven't seen him comment on
it in his blog or anything; might be worth asking him about it.

What do you think is best to do? I propose:

- Be sure to update README.chromium.
- Keep google.patch and mixed-sources.patch, but update both to be modern.
- Use an up to date version of jtkukunas' patches, and track that explicitly.

https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/contri...
File third_party/zlib/contrib/minizip/unzip.c (right):

https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/contri...
third_party/zlib/contrib/minizip/unzip.c:1707: 
We're missing a chuck of code here that seems like it was added in zlib-1.2.3!

    if ((len>pfile_in_zip_read_info->rest_read_uncompressed) &&
        (!(pfile_in_zip_read_info->raw)))
        pfile_in_zip_read_info->stream.avail_out =
            (uInt)pfile_in_zip_read_info->rest_read_uncompressed;

Do you know why?

https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/crc32.c
File third_party/zlib/crc32.c (right):

https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/crc32....
third_party/zlib/crc32.c:32: #include "x86.h"
Why are these here? They aren't part of zlib 1.2.5, zlib 1.2.8 or jtkukunas'
SIMD patches.

[gavinp, 2016-05-17 14:40:35]

Two things that make life a lot easier here: Mark Adler and Jim Kukunas both
maintain github repos of their work, see https://github.com/madler/zlib and
https://github.com/jtkukunas/zlib .

- Gavin

[gavinp, 2016-05-17 14:56:41]

https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/crc32.c
File third_party/zlib/crc32.c (right):

https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/crc32....
third_party/zlib/crc32.c:32: #include "x86.h"
On 2016/05/17 14:35:30, gavinp wrote:
> Why are these here? They aren't part of zlib 1.2.5, zlib 1.2.8 or jtkukunas'
> SIMD patches.

Well, I've solved this mystery, at least. It looks like it came out of the
review process for integrating the SIMD patches:
https://codereview.chromium.org/552123005/diff/40001/third_party/zlib/crc32.c

[gavinp, 2016-05-23 00:11:08]

On 2016/05/17 14:56:41, gavinp wrote:
> https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/crc32.c
> File third_party/zlib/crc32.c (right):
> 
>
https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/crc32....
> third_party/zlib/crc32.c:32: #include "x86.h"
> On 2016/05/17 14:35:30, gavinp wrote:
> > Why are these here? They aren't part of zlib 1.2.5, zlib 1.2.8 or jtkukunas'
> > SIMD patches.
> 
> Well, I've solved this mystery, at least. It looks like it came out of the
> review process for integrating the SIMD patches:
> https://codereview.chromium.org/552123005/diff/40001/third_party/zlib/crc32.c

Jiadong, ping?

I think this is worth doing; I'm sorry if my reviews have been difficult, but I
also think it's worth doing right. Do you want to move this forward?

[jiadong.zhu, 2016-05-23 01:24:05]

On 2016/05/23 00:11:08, gavinp wrote:
> On 2016/05/17 14:56:41, gavinp wrote:
> >
https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/crc32.c
> > File third_party/zlib/crc32.c (right):
> > 
> >
>
https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/crc32....
> > third_party/zlib/crc32.c:32: #include "x86.h"
> > On 2016/05/17 14:35:30, gavinp wrote:
> > > Why are these here? They aren't part of zlib 1.2.5, zlib 1.2.8 or
jtkukunas'
> > > SIMD patches.
> > 
> > Well, I've solved this mystery, at least. It looks like it came out of the
> > review process for integrating the SIMD patches:
> >
https://codereview.chromium.org/552123005/diff/40001/third_party/zlib/crc32.c
> 
> Jiadong, ping?
> 
> I think this is worth doing; I'm sorry if my reviews have been difficult, but
I
> also think it's worth doing right. Do you want to move this forward?

Sorry for delay, I will upload patch when its ready

[jiadong.zhu, 2016-05-23 09:11:20]

separate into 3 patches, please check

https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/contri...
File third_party/zlib/contrib/minizip/unzip.c (right):

https://codereview.chromium.org/1955383002/diff/40001/third_party/zlib/contri...
third_party/zlib/contrib/minizip/unzip.c:1707: 
On 2016/05/17 14:35:30, gavinp wrote:
> We're missing a chuck of code here that seems like it was added in zlib-1.2.3!
> 
>     if ((len>pfile_in_zip_read_info->rest_read_uncompressed) &&
>         (!(pfile_in_zip_read_info->raw)))
>         pfile_in_zip_read_info->stream.avail_out =
>             (uInt)pfile_in_zip_read_info->rest_read_uncompressed;
> 
> Do you know why?

I see https://codereview.chromium.org/222243003 remove this chunk

[gavinp, 2016-05-23 13:20:46]

lgtm. Thanks!

[gavinp, 2016-05-23 13:24:52]

Jiadong, I just saw you're not yet in AUTHORS. You need to add yourself to
AUTHORS in this patch per https://www.chromium.org/developers/contributing-code
. I see that you've already signed the contributors agreement.

[jiadong.zhu, 2016-05-24 01:09:58]

On 2016/05/23 13:24:52, gavinp wrote:
> Jiadong, I just saw you're not yet in AUTHORS. You need to add yourself to
> AUTHORS in this patch per
https://www.chromium.org/developers/contributing-code
> . I see that you've already signed the contributors agreement.

updated the AUTHORS file, thanks.

[gavinp, 2016-05-24 13:10:58]

The CQ bit was checked by gavinp@chromium.org

[gavinp, 2016-05-24 13:10:59]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1955383002/#ps80001
(title: "Add into author list")

[commit-bot: I haz the power, 2016-05-24 13:11:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955383002/80001

[gavinp, 2016-05-24 13:11:16]

On 2016/05/24 01:09:58, jiadong.zhu wrote:
> On 2016/05/23 13:24:52, gavinp wrote:
> > Jiadong, I just saw you're not yet in AUTHORS. You need to add yourself to
> > AUTHORS in this patch per
> https://www.chromium.org/developers/contributing-code
> > . I see that you've already signed the contributors agreement.
> 
> updated the AUTHORS file, thanks.

Great, I've gone ahead and just put this in the commit queue. Thank you for your
contribution!

[gavinp, 2016-05-24 13:23:05]

On 2016/05/24 13:11:16, gavinp wrote:
> On 2016/05/24 01:09:58, jiadong.zhu wrote:
> > On 2016/05/23 13:24:52, gavinp wrote:
> > > Jiadong, I just saw you're not yet in AUTHORS. You need to add yourself to
> > > AUTHORS in this patch per
> > https://www.chromium.org/developers/contributing-code
> > > . I see that you've already signed the contributors agreement.
> > 
> > updated the AUTHORS file, thanks.
> 
> Great, I've gone ahead and just put this in the commit queue. Thank you for
your
> contribution!

Oops, looks like there's some funniness around the symbol munging. Is this
mozzdefs?

[commit-bot: I haz the power, 2016-05-24 13:24:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 13:24:20]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[jiadong.zhu, 2016-05-25 03:24:09]

On 2016/05/24 13:23:05, gavinp wrote:
> On 2016/05/24 13:11:16, gavinp wrote:
> > On 2016/05/24 01:09:58, jiadong.zhu wrote:
> > > On 2016/05/23 13:24:52, gavinp wrote:
> > > > Jiadong, I just saw you're not yet in AUTHORS. You need to add yourself
to
> > > > AUTHORS in this patch per
> > > https://www.chromium.org/developers/contributing-code
> > > > . I see that you've already signed the contributors agreement.
> > > 
> > > updated the AUTHORS file, thanks.
> > 
> > Great, I've gone ahead and just put this in the commit queue. Thank you for
> your
> > contribution!
> 
> Oops, looks like there's some funniness around the symbol munging. Is this
> mozzdefs?

yes, I updated the patchset. please run the robot again, thanks

[gavinp, 2016-05-25 13:49:29]

The CQ bit was checked by gavinp@chromium.org

[gavinp, 2016-05-25 13:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1955383002/#ps100001
(title: "fix mozzdefs issue")

[commit-bot: I haz the power, 2016-05-25 13:49:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955383002/100001

[commit-bot: I haz the power, 2016-05-25 14:14:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 14:14:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jiadong.zhu, 2016-05-27 09:19:57]

https://codereview.chromium.org/1955383002/diff/100001/third_party/zlib/defla...
File third_party/zlib/deflate.c (right):

https://codereview.chromium.org/1955383002/diff/100001/third_party/zlib/defla...
third_party/zlib/deflate.c:363: int ZEXPORT deflateSetDictionary (strm,
dictionary, dictLength)
From debug, I found this chunk of code caused spdy failure, I am not sure why,
need to look into it.

[jiadong.zhu, 2016-05-31 11:48:01]

https://codereview.chromium.org/1955383002/diff/100001/third_party/zlib/defla...
File third_party/zlib/deflate.c (right):

https://codereview.chromium.org/1955383002/diff/100001/third_party/zlib/defla...
third_party/zlib/deflate.c:405: str = s->strstart;
When simd is enabled, 'insert_string' makes different hash from UPDATE_HASH, 
I found the simd optimisations is introduced from
https://codereview.chromium.org/678423002. It's weird that we use _asm_crc32
without changing the UPDATE_HASH to crc version, which causes the function
insert_string_sse and insert_string_c make different result.

[jiadong.zhu, 2016-06-02 05:03:31]

Hi gavin
I have updated the patch, please help run the bots again. Thanks.

https://codereview.chromium.org/1955383002/diff/120001/third_party/zlib/defla...
File third_party/zlib/deflate.c (right):

https://codereview.chromium.org/1955383002/diff/120001/third_party/zlib/defla...
third_party/zlib/deflate.c:408: insert_string(s, str);
changed to insert_string to keep integration of simd hash implement.

[gavinp, 2016-06-03 14:35:56]

The CQ bit was checked by gavinp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 14:36:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955383002/120001

[gavinp, 2016-06-03 14:38:37]

On 2016/06/02 05:03:31, jiadong.zhu wrote:
> Hi gavin
> I have updated the patch, please help run the bots again. Thanks.
> 
>
https://codereview.chromium.org/1955383002/diff/120001/third_party/zlib/defla...
> File third_party/zlib/deflate.c (right):
> 
>
https://codereview.chromium.org/1955383002/diff/120001/third_party/zlib/defla...
> third_party/zlib/deflate.c:408: insert_string(s, str);
> changed to insert_string to keep integration of simd hash implement.

Jiadong,

Thanks for all the work; these updates of zlib all go like this unfortunately.

I'm going to re-review it because I'm a bit anxious about this integration, so
I'm doing a CQ dry-run to test everything, then I'll give it my once over and
hopefully a second ell gee tee em

[commit-bot: I haz the power, 2016-06-03 15:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 15:02:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jiadong.zhu, 2016-06-07 12:44:46]

On 2016/06/03 15:02:53, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

from the failure on jobs, the result of compression is a little smaller than the
expect value, which to some extend is the improvement.

the following commit cause the output shrink.
https://github.com/madler/zlib/commit/9d55abc96968db80749df5ebf412d36e2d66de26

[gavinp, 2016-06-07 14:12:10]

On 2016/06/07 12:44:46, jiadong.zhu wrote:
> On 2016/06/03 15:02:53, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
> (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> from the failure on jobs, the result of compression is a little smaller than
the
> expect value, which to some extend is the improvement.
> 
> the following commit cause the output shrink.
> https://github.com/madler/zlib/commit/9d55abc96968db80749df5ebf412d36e2d66de26

Great, so if you update the patch with the fixed tests, we'll be good to go. I'm
an OWNER in net/ as well, so we can just continue after that.

[jiadong.zhu, 2016-06-08 08:10:07]

Patchset #7 (id:140001) has been deleted

[jiadong.zhu, 2016-06-08 09:16:24]

I modifyed the expected result and run gtest net_unittests successfully on my
laptop.

[gavinp, 2016-06-10 19:44:15]

The CQ bit was checked by gavinp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 19:44:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/160001

[commit-bot: I haz the power, 2016-06-10 19:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 19:54:15]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jiadong.zhu, 2016-06-11 02:54:42]

forget to add into AUTHOR list in the latest patch. now it ok.

[gavinp, 2016-06-14 13:46:45]

The CQ bit was checked by gavinp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 13:47:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/180001

[commit-bot: I haz the power, 2016-06-14 14:32:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 14:32:38]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jiadong.zhu, 2016-06-15 04:04:35]

The CQ bit was checked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-15 04:04:36]

The CQ bit was unchecked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-15 04:04:36]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1955383002/#ps180001
(title: "update AUTHORS file")

[jiadong.zhu, 2016-06-15 04:04:37]

The CQ bit was checked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-15 04:04:37]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1955383002/#ps180001
(title: "update AUTHORS file")

[jiadong.zhu, 2016-06-15 04:04:38]

The CQ bit was checked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-15 04:04:38]

The CQ bit was unchecked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-15 04:04:39]

The CQ bit was unchecked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-15 04:04:48]

The CQ bit was checked by jiadong.zhu@linaro.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 04:05:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/180001

[commit-bot: I haz the power, 2016-06-15 05:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 05:13:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gavinp, 2016-06-16 18:58:08]

The CQ bit was checked by gavinp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 18:58:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/180001

[commit-bot: I haz the power, 2016-06-16 19:02:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 19:02:48]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jiadong.zhu, 2016-06-17 11:11:26]

The CQ bit was checked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-17 11:11:26]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1955383002/#ps200001
(title: "fix win x64 failure")

[commit-bot: I haz the power, 2016-06-17 11:11:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/200001

[commit-bot: I haz the power, 2016-06-17 12:44:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 12:44:45]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jiadong.zhu, 2016-06-20 01:57:29]

The CQ bit was checked by jiadong.zhu@linaro.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 01:57:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/200001

[commit-bot: I haz the power, 2016-06-20 03:02:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 03:02:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jiadong.zhu, 2016-06-20 09:20:23]

The CQ bit was checked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-20 09:20:24]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1955383002/#ps220001
(title: "fix unzip on win platform")

[jiadong.zhu, 2016-06-20 09:20:25]

The CQ bit was checked by jiadong.zhu@linaro.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 09:20:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/220001

[commit-bot: I haz the power, 2016-06-20 10:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 10:42:12]

Dry run: This issue passed the CQ dry run.

[jiadong.zhu, 2016-06-20 10:43:45]

The CQ bit was checked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-20 10:43:56]

The CQ bit was unchecked by jiadong.zhu@linaro.org

[jiadong.zhu, 2016-06-20 10:43:57]

The CQ bit was checked by jiadong.zhu@linaro.org

[commit-bot: I haz the power, 2016-06-20 10:44:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955383002/220001

[commit-bot: I haz the power, 2016-06-20 11:10:05]

Description was changed from

==========
Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged
to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an
empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these
enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw
mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on
any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements


BUG=610615
R=agl@chromium.org
R=gavinp@chromium.org
==========

to

==========
Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged
to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an
empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these
enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw
mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on
any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements


BUG=610615
R=agl@chromium.org
R=gavinp@chromium.org
==========

[commit-bot: I haz the power, 2016-06-20 11:10:07]

Committed patchset #10 (id:220001)

[commit-bot: I haz the power, 2016-06-20 11:12:00]

Description was changed from

==========
Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged
to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an
empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these
enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw
mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on
any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements


BUG=610615
R=agl@chromium.org
R=gavinp@chromium.org
==========

to

==========
Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged
to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an
empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these
enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw
mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on
any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements

BUG=610615
R=agl@chromium.org
R=gavinp@chromium.org

Committed: https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883
Cr-Commit-Position: refs/heads/master@{#400647}
==========

[commit-bot: I haz the power, 2016-06-20 11:12:03]

Patchset 10 (id:??) landed as
https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883
Cr-Commit-Position: refs/heads/master@{#400647}

[Jamie Madill, 2016-06-20 13:57:30]

A revert of this CL (patchset #10 id:220001) has been created in
https://codereview.chromium.org/2079313002/ by jmadill@chromium.org.

The reason for reverting is: Broke the Windows Debug GPU FYI builder:

https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20...

fx_zlib.gzlib.obj : error LNK2005: _gzopen_w already defined in zlib.gzlib.obj

initial\chrome.dll : fatal error LNK1169: one or more multiply defined symbols
found

Possibly because they use shared components with a GYP build..