Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: BUILD.gn

Issue 1955353002: Revert of Add GN targets for samples (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 00ccf656f0987fc6fb46bf0663cdb1b897d40dfb..f3d670daf961bc7bb3c21d10fbe194d3e91fb2c0 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2254,59 +2254,3 @@
":toolchain",
]
}
-
-executable("hello-world") {
- sources = [
- "samples/hello-world.cc",
- ]
-
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [
- # Note: don't use :internal_config here because this target will get
- # the :external_config applied to it by virtue of depending on :v8, and
- # you can't have both applied to the same target.
- ":internal_config_base",
- ":features",
- ":toolchain",
- ]
-
- deps = [
- ":v8",
- ":v8_libplatform",
- "//build/config/sanitizers:deps",
- "//build/win:default_exe_manifest",
- ]
-
- if (v8_enable_i18n_support) {
- deps += [ "//third_party/icu" ]
- }
-}
-
-executable("process") {
- sources = [
- "samples/process.cc",
- ]
-
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [
- # Note: don't use :internal_config here because this target will get
- # the :external_config applied to it by virtue of depending on :v8, and
- # you can't have both applied to the same target.
- ":internal_config_base",
- ":features",
- ":toolchain",
- ]
-
- deps = [
- ":v8",
- ":v8_libplatform",
- "//build/config/sanitizers:deps",
- "//build/win:default_exe_manifest",
- ]
-
- if (v8_enable_i18n_support) {
- deps += [ "//third_party/icu" ]
- }
-}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698