Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1955353002: Revert of Add GN targets for samples (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add GN targets for samples (patchset #1 id:1 of https://codereview.chromium.org/1955723003/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1956223002/ Original issue's description: > Add GN targets for samples > > BUG=chromium:609107 > R=machenbach@chromium.org > LOG=n > > Committed: https://crrev.com/19a8e09cc0bafa5071c52243234bfc8512210065 > Cr-Commit-Position: refs/heads/master@{#36072} TBR=machenbach@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:609107 LOG=n Committed: https://crrev.com/369dcca7a543318194d66aaca4cb71e90bff9240 Cr-Commit-Position: refs/heads/master@{#36096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Hablich
Created Revert of Add GN targets for samples
4 years, 7 months ago (2016-05-09 06:41:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955353002/1
4 years, 7 months ago (2016-05-09 06:41:24 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14817)
4 years, 7 months ago (2016-05-09 06:44:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955353002/1
4 years, 7 months ago (2016-05-09 06:48:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 07:17:33 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/369dcca7a543318194d66aaca4cb71e90bff9240 Cr-Commit-Position: refs/heads/master@{#36096}
4 years, 7 months ago (2016-05-09 07:18:10 UTC) #11
Michael Achenbach
4 years, 7 months ago (2016-05-09 08:45:40 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698