Mac: Use a "less" private API for keeping traffic lights lit while bubbles are showing

Mac: Use a "less" private API for keeping traffic lights lit while bubbles are showing

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -_sharesParentKeyState. info_bubble_window.mm still
uses this, and it causes a lot of complex interactions with hotkeys and
dialog dismissal. Leave this for a follow-up since it will be tricky to
ensure there are no regressions while unwinding the existing workarounds
for _sharesParentKeyState weirdness.

This would also give a nice way to keep traffic lights lit when WebModal
dialogs are showing. This isn't currently done, and would make their
behaviour more consistent with native sheets. However, WebModals are
actually *grand*-children of the Cocoa browser window and have other
complications. Leave that for a follow-up as well.

BUG=602846, 603881
Committed: https://crrev.com/1b0d712e570d6800634910954d6a6690b1ae5d17
Cr-Commit-Position: refs/heads/master@{#392448}

[tapted, 2016-05-09 05:39:43]

Description was changed from

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

As a nice bonus, also keep traffic lights lit when WebModal dialogs are
showing. This makes the behaviour more consistent with native sheets.

BUG=602846, 603881
==========

to

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

As a nice bonus, on a Cocoa browser, also keep traffic lights lit when
WebModal dialogs are showing. This makes their behaviour more consistent
with native sheets.

After this, we should be able to phase out the overrides of the slightly
"more" private API -[NSWindow _sharesParentKeyState] that
info_bubble_window.mm still uses. However, there are lots of
interactions with hotkeys and things to sort out first.

BUG=602846, 603881
==========

[tapted, 2016-05-09 05:39:43]

tapted@chromium.org changed reviewers:
+ rsesek@chromium.org

[tapted, 2016-05-09 05:48:25]

Description was changed from

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

As a nice bonus, on a Cocoa browser, also keep traffic lights lit when
WebModal dialogs are showing. This makes their behaviour more consistent
with native sheets.

After this, we should be able to phase out the overrides of the slightly
"more" private API -[NSWindow _sharesParentKeyState] that
info_bubble_window.mm still uses. However, there are lots of
interactions with hotkeys and things to sort out first.

BUG=602846, 603881
==========

to

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

As a nice bonus, on a Cocoa browser, also keep traffic lights lit when
WebModal dialogs are showing. This makes their behaviour more consistent
with native sheets.

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -[NSWindow _sharesParentKeyState] that
info_bubble_window.mm still uses, and causes lots of complex
interactions with hotkeys and dialog dismissal. Leave this for a
follow-up since it will be tricky to ensure there are no regressions
while unwinding the existing workarounds for _sharesParentKeyState
weirdness.

BUG=602846, 603881
==========

[tapted, 2016-05-09 06:29:29]

Description was changed from

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

As a nice bonus, on a Cocoa browser, also keep traffic lights lit when
WebModal dialogs are showing. This makes their behaviour more consistent
with native sheets.

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -[NSWindow _sharesParentKeyState] that
info_bubble_window.mm still uses, and causes lots of complex
interactions with hotkeys and dialog dismissal. Leave this for a
follow-up since it will be tricky to ensure there are no regressions
while unwinding the existing workarounds for _sharesParentKeyState
weirdness.

BUG=602846, 603881
==========

to

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

As a nice bonus, on a Cocoa browser, also keep traffic lights lit when
WebModal dialogs are showing. This makes their behaviour more consistent
with native sheets.

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -_sharesParentKeyState. info_bubble_window.mm still
uses this, and it causes a lot of complex interactions with hotkeys and
dialog dismissal. Leave this for a follow-up since it will be tricky to
ensure there are no regressions while unwinding the existing workarounds
for _sharesParentKeyState weirdness.

BUG=602846, 603881
==========

[tapted, 2016-05-09 06:53:41]

Description was changed from

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

As a nice bonus, on a Cocoa browser, also keep traffic lights lit when
WebModal dialogs are showing. This makes their behaviour more consistent
with native sheets.

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -_sharesParentKeyState. info_bubble_window.mm still
uses this, and it causes a lot of complex interactions with hotkeys and
dialog dismissal. Leave this for a follow-up since it will be tricky to
ensure there are no regressions while unwinding the existing workarounds
for _sharesParentKeyState weirdness.

BUG=602846, 603881
==========

to

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -_sharesParentKeyState. info_bubble_window.mm still
uses this, and it causes a lot of complex interactions with hotkeys and
dialog dismissal. Leave this for a follow-up since it will be tricky to
ensure there are no regressions while unwinding the existing workarounds
for _sharesParentKeyState weirdness.

This would also give a nice way to keep traffic lights lit when WebModal
dialogs are showing. This isn't currently done, and would make their
behaviour more consistent with native sheets. However, WebModals are
actually *grand*-children of the Cocoa browser window and have other
complications. Leave that for a follow-up as well.

BUG=602846, 603881
==========

[tapted, 2016-05-09 08:11:58]

Hi Robert, please take a look. (lots of follow-ups, but this will at least fix
http://crbug.com/602846 which is super-annoying)

[Robert Sesek, 2016-05-09 18:12:19]

LGTM, though I haven't researched what exactly this new method you found does.

[tapted, 2016-05-09 22:26:42]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-05-09 22:27:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955343002/40001

[commit-bot: I haz the power, 2016-05-09 22:31:47]

Description was changed from

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -_sharesParentKeyState. info_bubble_window.mm still
uses this, and it causes a lot of complex interactions with hotkeys and
dialog dismissal. Leave this for a follow-up since it will be tricky to
ensure there are no regressions while unwinding the existing workarounds
for _sharesParentKeyState weirdness.

This would also give a nice way to keep traffic lights lit when WebModal
dialogs are showing. This isn't currently done, and would make their
behaviour more consistent with native sheets. However, WebModals are
actually *grand*-children of the Cocoa browser window and have other
complications. Leave that for a follow-up as well.

BUG=602846, 603881
==========

to

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -_sharesParentKeyState. info_bubble_window.mm still
uses this, and it causes a lot of complex interactions with hotkeys and
dialog dismissal. Leave this for a follow-up since it will be tricky to
ensure there are no regressions while unwinding the existing workarounds
for _sharesParentKeyState weirdness.

This would also give a nice way to keep traffic lights lit when WebModal
dialogs are showing. This isn't currently done, and would make their
behaviour more consistent with native sheets. However, WebModals are
actually *grand*-children of the Cocoa browser window and have other
complications. Leave that for a follow-up as well.

BUG=602846, 603881
==========

[commit-bot: I haz the power, 2016-05-09 22:31:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-09 22:33:06]

Description was changed from

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -_sharesParentKeyState. info_bubble_window.mm still
uses this, and it causes a lot of complex interactions with hotkeys and
dialog dismissal. Leave this for a follow-up since it will be tricky to
ensure there are no regressions while unwinding the existing workarounds
for _sharesParentKeyState weirdness.

This would also give a nice way to keep traffic lights lit when WebModal
dialogs are showing. This isn't currently done, and would make their
behaviour more consistent with native sheets. However, WebModals are
actually *grand*-children of the Cocoa browser window and have other
complications. Leave that for a follow-up as well.

BUG=602846, 603881
==========

to

==========
Mac: Use a "less" private API for keeping traffic lights lit while bubbles are
showing

The approach: Rather than overriding -[NSWindow _sharesParentKeyState]
on the child, override -[NSWindow hasKeyAppearance] on the parent.  This
is used, e.g., by WebKit since http://wkrev.com/164173. It doesn't have
an underscore on the front which I guess is nice.

After this, we should be able to phase out the overrides of the slightly
"more" private API -_sharesParentKeyState. info_bubble_window.mm still
uses this, and it causes a lot of complex interactions with hotkeys and
dialog dismissal. Leave this for a follow-up since it will be tricky to
ensure there are no regressions while unwinding the existing workarounds
for _sharesParentKeyState weirdness.

This would also give a nice way to keep traffic lights lit when WebModal
dialogs are showing. This isn't currently done, and would make their
behaviour more consistent with native sheets. However, WebModals are
actually *grand*-children of the Cocoa browser window and have other
complications. Leave that for a follow-up as well.

BUG=602846, 603881

Committed: https://crrev.com/1b0d712e570d6800634910954d6a6690b1ae5d17
Cr-Commit-Position: refs/heads/master@{#392448}
==========

[commit-bot: I haz the power, 2016-05-09 22:33:07]

Patchset 3 (id:??) landed as
https://crrev.com/1b0d712e570d6800634910954d6a6690b1ae5d17
Cr-Commit-Position: refs/heads/master@{#392448}