tools/viewer/sk_app/Window.h - Issue 1955293002: Add flexible keybinding/command system to sk_app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/viewer/sk_app/Window.h

Issue 1955293002: Add flexible keybinding/command system to sk_app (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Extract keybinding system as CommandSet. Add grouping and two help modes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/viewer/sk_app/Window.h

diff --git a/tools/viewer/sk_app/Window.h b/tools/viewer/sk_app/Window.h

index 56444a67b76639577e9b0e24a7b506c6bce1a54a..48fd4ecdb860a275e356f9fa1e07a110a966c4ef 100644

--- a/tools/viewer/sk_app/Window.h

+++ b/tools/viewer/sk_app/Window.h

@@ -41,7 +41,7 @@ public:

void detach();

// input handling

- enum Key {

+ enum class Key {

bsalomon 2016/05/09 20:25:53 When we use enum class we drop the _<Type> suffix

kNONE_Key, //corresponds to android's UNKNOWN

kLeftSoftKey_Key,

@@ -79,7 +79,7 @@ public:

kLast_Key = kCamera_Key

};

- static const int kKeyCount = kLast_Key + 1;

+ static const int kKeyCount = static_cast<int>(Key::kLast_Key) + 1;

enum ModifierKeys {

kShift_ModifierKey = 1 << 0,