No error if function marked with SK_WARN_UNUSED_RESULT is used in SkAssertResult

No error if function marked with SK_WARN_UNUSED_RESULT is used in SkAssertResult
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955263002

Committed: https://skia.googlesource.com/skia/+/9daa4b92d73a1ae441c864a0ae73dda6c3397acb

[bsalomon, 2016-05-08 00:46:24]

Description was changed from

==========
No error if function marked with SK_WARN_UNUSED_RESULT is used in SkAssertResult
==========

to

==========
No error if function marked with SK_WARN_UNUSED_RESULT is used in SkAssertResult
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-05-09 14:08:09]

bsalomon@google.com changed reviewers:
+ reed@google.com

[bsalomon, 2016-05-09 14:08:10]

Curious what you think of this. I have a function that returns a bool and is
tagged with SK_WARN_UNUSED_RESULT. However, I'm calling it in a place where the
preconditions mean that it will always return true so I put the call in
SkAssertResult(). This compiles in Debug but not Release. This change allows it
to compile in Release. 


I certainly can live without it. My intuition is that SK_WARN_UNUSED_RESULT is
meant to make the author of calling code think about the possible return values.
If the author uses SkAssertResult then presumably they did think about it.

[reed1, 2016-05-09 15:16:56]

lgtm

[bsalomon, 2016-05-09 15:50:15]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-05-09 15:50:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955263002/20001

[commit-bot: I haz the power, 2016-05-09 16:14:38]

Description was changed from

==========
No error if function marked with SK_WARN_UNUSED_RESULT is used in SkAssertResult
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
No error if function marked with SK_WARN_UNUSED_RESULT is used in SkAssertResult
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9daa4b92d73a1ae441c864a0ae73dda6c3397acb
==========

[commit-bot: I haz the power, 2016-05-09 16:14:39]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9daa4b92d73a1ae441c864a0ae73dda6c3397acb