Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1955243002: Trim ResourceTimingInfoMap of non-relevant entries. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
haraken, Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trim ResourceTimingInfoMap of non-relevant entries. If the resource fetch fails or is otherwise uninteresting to report a ResourceTimingInfo for, remove it (also) from the set of pending map of such ResourceTimingInfos. R= BUG=608543 Committed: https://crrev.com/f66d9059093dffbc634d997ff15afe9169916fdf Cr-Commit-Position: refs/heads/master@{#392307}

Patch Set 1 #

Patch Set 2 : remove resources that fail to load also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 35 (18 generated)
sof
please take a look. Retaining Resources that failed etc by this ResourceFetcher map doesn't look ...
4 years, 7 months ago (2016-05-07 16:46:44 UTC) #4
haraken
LGTM
4 years, 7 months ago (2016-05-07 16:56:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
4 years, 7 months ago (2016-05-07 17:59:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223859)
4 years, 7 months ago (2016-05-07 19:00:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
4 years, 7 months ago (2016-05-07 20:16:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223873)
4 years, 7 months ago (2016-05-07 21:33:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
4 years, 7 months ago (2016-05-08 04:32:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223903)
4 years, 7 months ago (2016-05-08 05:34:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
4 years, 7 months ago (2016-05-08 11:39:29 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223924)
4 years, 7 months ago (2016-05-08 12:37:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
4 years, 7 months ago (2016-05-08 20:18:41 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223966)
4 years, 7 months ago (2016-05-08 21:16:04 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
4 years, 7 months ago (2016-05-09 05:06:28 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/224063)
4 years, 7 months ago (2016-05-09 06:07:03 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
4 years, 7 months ago (2016-05-09 13:14:05 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 14:17:07 UTC) #33
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 14:18:31 UTC) #35
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f66d9059093dffbc634d997ff15afe9169916fdf
Cr-Commit-Position: refs/heads/master@{#392307}

Powered by Google App Engine
This is Rietveld 408576698