Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1955243002:
Trim ResourceTimingInfoMap of non-relevant entries. (Closed)
|
Created:
4 years, 7 months ago by sof Modified:
4 years, 7 months ago CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTrim ResourceTimingInfoMap of non-relevant entries.
If the resource fetch fails or is otherwise uninteresting to report a
ResourceTimingInfo for, remove it (also) from the set of pending
map of such ResourceTimingInfos.
R=
BUG=608543
Committed: https://crrev.com/f66d9059093dffbc634d997ff15afe9169916fdf
Cr-Commit-Position: refs/heads/master@{#392307}
Patch Set 1 #Patch Set 2 : remove resources that fail to load also #Messages
Total messages: 35 (18 generated)
Description was changed from ========== Trim ResourceTimingInfoMap of non-relevant entries. R= BUG= ========== to ========== Trim ResourceTimingInfoMap of non-relevant entries. R= BUG=608543 ==========
Description was changed from ========== Trim ResourceTimingInfoMap of non-relevant entries. R= BUG=608543 ========== to ========== Trim ResourceTimingInfoMap of non-relevant entries. If the resource fetch fails or is otherwise uninteresting to report a ResourceTimingInfo for, remove it (also) from the set of pending map of such ResourceTimingInfos. R= BUG=608543 ==========
sigbjornf@opera.com changed reviewers: + haraken@chromium.org, japhet@chromium.org
please take a look. Retaining Resources that failed etc by this ResourceFetcher map doesn't look beneficial.
LGTM
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955243002/20001
Message was sent while issue was closed.
Description was changed from ========== Trim ResourceTimingInfoMap of non-relevant entries. If the resource fetch fails or is otherwise uninteresting to report a ResourceTimingInfo for, remove it (also) from the set of pending map of such ResourceTimingInfos. R= BUG=608543 ========== to ========== Trim ResourceTimingInfoMap of non-relevant entries. If the resource fetch fails or is otherwise uninteresting to report a ResourceTimingInfo for, remove it (also) from the set of pending map of such ResourceTimingInfos. R= BUG=608543 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Trim ResourceTimingInfoMap of non-relevant entries. If the resource fetch fails or is otherwise uninteresting to report a ResourceTimingInfo for, remove it (also) from the set of pending map of such ResourceTimingInfos. R= BUG=608543 ========== to ========== Trim ResourceTimingInfoMap of non-relevant entries. If the resource fetch fails or is otherwise uninteresting to report a ResourceTimingInfo for, remove it (also) from the set of pending map of such ResourceTimingInfos. R= BUG=608543 Committed: https://crrev.com/f66d9059093dffbc634d997ff15afe9169916fdf Cr-Commit-Position: refs/heads/master@{#392307} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f66d9059093dffbc634d997ff15afe9169916fdf Cr-Commit-Position: refs/heads/master@{#392307} |
