Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1955233002: Revert of Memory copy the VideoFrame to match the requirement for HW encoders. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
xjz, xhwang, miu
CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Memory copy the VideoFrame to match the requirement for HW encoders. (patchset #8 id:240001 of https://codereview.chromium.org/1913503002/ ) Reason for revert: Turns msan red: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/15793/steps/media_unittests%20on%20Ubuntu-12.04/logs/VideoUtilTest.I420CopyWithPadding [ RUN ] VideoUtilTest.I420CopyWithPadding ==2446==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xc369b7 in VerifyPlanCopyWithPadding media/base/video_util_unittest.cc:44:11 #1 0xc32802 in VerifyCopyWithPadding media/base/video_util_unittest.cc:62:8 #2 0xc307b5 in TestBody media/base/video_util_unittest.cc:468:3 Original issue's description: > Memory copy the VideoFrame to match the requirement for HW encoders. > > BUG=578938 > > Committed: https://crrev.com/957fd159c32d6a62718993e9758a9a5c276e000a > Cr-Commit-Position: refs/heads/master@{#392098} TBR=miu@chromium.org,xhwang@chromium.org,xjz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=578938 Committed: https://crrev.com/089202e2c9d505224bb0894e731378c28ad858b4 Cr-Commit-Position: refs/heads/master@{#392259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -339 lines) Patch
M media/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/video_util.h View 1 chunk +0 lines, -19 lines 0 comments Download
M media/base/video_util.cc View 3 chunks +0 lines, -79 lines 0 comments Download
M media/base/video_util_unittest.cc View 2 chunks +0 lines, -116 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 11 chunks +8 lines, -117 lines 0 comments Download
M media/cast/sender/size_adaptable_video_encoder_base.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/cast/sender/video_sender.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of Memory copy the VideoFrame to match the requirement for HW encoders.
4 years, 7 months ago (2016-05-07 14:14:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955233002/1
4 years, 7 months ago (2016-05-07 14:14:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-07 14:14:58 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 14:16:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/089202e2c9d505224bb0894e731378c28ad858b4
Cr-Commit-Position: refs/heads/master@{#392259}

Powered by Google App Engine
This is Rietveld 408576698